ui: remove release notes modal

This commit is contained in:
Aaron Greenspan
2021-01-29 14:30:18 -07:00
committed by Aiden McClelland
parent 0e87cce8de
commit 0d7b087665
6 changed files with 2 additions and 68 deletions

View File

@@ -1,15 +0,0 @@
import { NgModule } from '@angular/core'
import { CommonModule } from '@angular/common'
import { IonicModule } from '@ionic/angular'
import { AppReleaseNotesPage } from './app-release-notes.page'
import { SharingModule } from 'src/app/modules/sharing.module'
@NgModule({
imports: [
CommonModule,
IonicModule,
SharingModule,
],
declarations: [AppReleaseNotesPage],
})
export class AppReleaseNotesPageModule { }

View File

@@ -1,14 +0,0 @@
<ion-header>
<ion-toolbar>
<ion-buttons slot="start">
<ion-button (click)="dismiss()">
<ion-icon slot="icon-only" name="close"></ion-icon>
</ion-button>
</ion-buttons>
<ion-title style="font-size: 16px;">{{ version | displayEmver }} Release Notes</ion-title>
</ion-toolbar>
</ion-header>
<ion-content class="ion-padding">
<div [innerHTML]="releaseNotes | markdown"></div>
</ion-content>

View File

@@ -1,20 +0,0 @@
import { Component, Input } from '@angular/core'
import { ModalController } from '@ionic/angular'
@Component({
selector: 'app-release-notes',
templateUrl: './app-release-notes.page.html',
styleUrls: ['./app-release-notes.page.scss'],
})
export class AppReleaseNotesPage {
@Input() releaseNotes: string
@Input() version: string
constructor (
private readonly modalCtrl: ModalController,
) { }
dismiss () {
this.modalCtrl.dismiss()
}
}

View File

@@ -12,7 +12,6 @@ import { RecommendationButtonComponentModule } from 'src/app/components/recommen
import { InstallWizardComponentModule } from 'src/app/components/install-wizard/install-wizard.component.module'
import { ErrorMessageComponentModule } from 'src/app/components/error-message/error-message.component.module'
import { InformationPopoverComponentModule } from 'src/app/components/information-popover/information-popover.component.module'
import { AppReleaseNotesPageModule } from 'src/app/modals/app-release-notes/app-release-notes.module'
const routes: Routes = [
{
@@ -35,7 +34,6 @@ const routes: Routes = [
InstallWizardComponentModule,
ErrorMessageComponentModule,
InformationPopoverComponentModule,
AppReleaseNotesPageModule,
],
declarations: [AppAvailableShowPage],
})

View File

@@ -4,8 +4,8 @@ import { AppAvailableFull, AppAvailableVersionSpecificInfo } from 'src/app/model
import { ApiService } from 'src/app/services/api/api.service'
import { AlertController, ModalController, NavController, PopoverController } from '@ionic/angular'
import { markAsLoadingDuring$ } from 'src/app/services/loader.service'
import { BehaviorSubject, combineLatest, from, merge, Observable, of } from 'rxjs'
import { catchError, concatMap, delay, filter, skip, switchMap, tap } from 'rxjs/operators'
import { BehaviorSubject, from, Observable, of } from 'rxjs'
import { catchError, concatMap, filter, switchMap, tap } from 'rxjs/operators'
import { Recommendation } from 'src/app/components/recommendation-button/recommendation-button.component'
import { wizardModal } from 'src/app/components/install-wizard/install-wizard.component'
import { WizardBaker } from 'src/app/components/install-wizard/prebaked-wizards'
@@ -13,7 +13,6 @@ import { AppModel } from 'src/app/models/app-model'
import { initPropertySubject, peekProperties, PropertySubject } from 'src/app/util/property-subject.util'
import { Cleanup } from 'src/app/util/cleanup'
import { InformationPopoverComponent } from 'src/app/components/information-popover/information-popover.component'
import { AppReleaseNotesPage } from 'src/app/modals/app-release-notes/app-release-notes.page'
import { Emver } from 'src/app/services/emver.service'
import { displayEmver } from 'src/app/pipes/emver.pipe'
@@ -189,20 +188,6 @@ export class AppAvailableShowPage extends Cleanup {
}
}
async presentModalReleaseNotes () {
const { releaseNotes, versionViewing } = peekProperties(this.$app$)
const modal = await this.modalCtrl.create({
component: AppReleaseNotesPage,
componentProps: {
releaseNotes,
version: versionViewing,
},
})
await modal.present()
}
private fetchRecommendation (): Observable<any> {
this.recommendation = history.state && history.state.installationRecommendation