From 0d7b08766575924ac7d151ea1717f856f3611727 Mon Sep 17 00:00:00 2001
From: Aaron Greenspan <afg419@gmail.com>
Date: Fri, 29 Jan 2021 14:30:18 -0700
Subject: [PATCH] ui: remove release notes modal

---
 .../app-release-notes.module.ts               | 15 --------------
 .../app-release-notes.page.html               | 14 -------------
 .../app-release-notes.page.scss               |  0
 .../app-release-notes.page.ts                 | 20 -------------------
 .../app-available-show.module.ts              |  2 --
 .../app-available-show.page.ts                | 19 ++----------------
 6 files changed, 2 insertions(+), 68 deletions(-)
 delete mode 100644 ui/src/app/modals/app-release-notes/app-release-notes.module.ts
 delete mode 100644 ui/src/app/modals/app-release-notes/app-release-notes.page.html
 delete mode 100644 ui/src/app/modals/app-release-notes/app-release-notes.page.scss
 delete mode 100644 ui/src/app/modals/app-release-notes/app-release-notes.page.ts

diff --git a/ui/src/app/modals/app-release-notes/app-release-notes.module.ts b/ui/src/app/modals/app-release-notes/app-release-notes.module.ts
deleted file mode 100644
index f6613d5b5..000000000
--- a/ui/src/app/modals/app-release-notes/app-release-notes.module.ts
+++ /dev/null
@@ -1,15 +0,0 @@
-import { NgModule } from '@angular/core'
-import { CommonModule } from '@angular/common'
-import { IonicModule } from '@ionic/angular'
-import { AppReleaseNotesPage } from './app-release-notes.page'
-import { SharingModule } from 'src/app/modules/sharing.module'
-
-@NgModule({
-  imports: [
-    CommonModule,
-    IonicModule,
-    SharingModule,
-  ],
-  declarations: [AppReleaseNotesPage],
-})
-export class AppReleaseNotesPageModule { }
diff --git a/ui/src/app/modals/app-release-notes/app-release-notes.page.html b/ui/src/app/modals/app-release-notes/app-release-notes.page.html
deleted file mode 100644
index 5094ff4f9..000000000
--- a/ui/src/app/modals/app-release-notes/app-release-notes.page.html
+++ /dev/null
@@ -1,14 +0,0 @@
-<ion-header>
-  <ion-toolbar>
-    <ion-buttons slot="start">
-      <ion-button (click)="dismiss()">
-        <ion-icon slot="icon-only" name="close"></ion-icon>
-      </ion-button>
-    </ion-buttons>
-    <ion-title style="font-size: 16px;">{{ version | displayEmver }} Release Notes</ion-title>
-  </ion-toolbar>
-</ion-header>
-
-<ion-content class="ion-padding">
-  <div [innerHTML]="releaseNotes | markdown"></div>
-</ion-content>
\ No newline at end of file
diff --git a/ui/src/app/modals/app-release-notes/app-release-notes.page.scss b/ui/src/app/modals/app-release-notes/app-release-notes.page.scss
deleted file mode 100644
index e69de29bb..000000000
diff --git a/ui/src/app/modals/app-release-notes/app-release-notes.page.ts b/ui/src/app/modals/app-release-notes/app-release-notes.page.ts
deleted file mode 100644
index 1c4c47dfa..000000000
--- a/ui/src/app/modals/app-release-notes/app-release-notes.page.ts
+++ /dev/null
@@ -1,20 +0,0 @@
-import { Component, Input } from '@angular/core'
-import { ModalController } from '@ionic/angular'
-
-@Component({
-  selector: 'app-release-notes',
-  templateUrl: './app-release-notes.page.html',
-  styleUrls: ['./app-release-notes.page.scss'],
-})
-export class AppReleaseNotesPage {
-  @Input() releaseNotes: string
-  @Input() version: string
-
-  constructor (
-    private readonly modalCtrl: ModalController,
-  ) { }
-
-  dismiss () {
-    this.modalCtrl.dismiss()
-  }
-}
diff --git a/ui/src/app/pages/apps-routes/app-available-show/app-available-show.module.ts b/ui/src/app/pages/apps-routes/app-available-show/app-available-show.module.ts
index 3bede4774..6becbdc70 100644
--- a/ui/src/app/pages/apps-routes/app-available-show/app-available-show.module.ts
+++ b/ui/src/app/pages/apps-routes/app-available-show/app-available-show.module.ts
@@ -12,7 +12,6 @@ import { RecommendationButtonComponentModule } from 'src/app/components/recommen
 import { InstallWizardComponentModule } from 'src/app/components/install-wizard/install-wizard.component.module'
 import { ErrorMessageComponentModule } from 'src/app/components/error-message/error-message.component.module'
 import { InformationPopoverComponentModule } from 'src/app/components/information-popover/information-popover.component.module'
-import { AppReleaseNotesPageModule } from 'src/app/modals/app-release-notes/app-release-notes.module'
 
 const routes: Routes = [
   {
@@ -35,7 +34,6 @@ const routes: Routes = [
     InstallWizardComponentModule,
     ErrorMessageComponentModule,
     InformationPopoverComponentModule,
-    AppReleaseNotesPageModule,
   ],
   declarations: [AppAvailableShowPage],
 })
diff --git a/ui/src/app/pages/apps-routes/app-available-show/app-available-show.page.ts b/ui/src/app/pages/apps-routes/app-available-show/app-available-show.page.ts
index ae37680eb..ad36eb014 100644
--- a/ui/src/app/pages/apps-routes/app-available-show/app-available-show.page.ts
+++ b/ui/src/app/pages/apps-routes/app-available-show/app-available-show.page.ts
@@ -4,8 +4,8 @@ import { AppAvailableFull, AppAvailableVersionSpecificInfo } from 'src/app/model
 import { ApiService } from 'src/app/services/api/api.service'
 import { AlertController, ModalController, NavController, PopoverController } from '@ionic/angular'
 import { markAsLoadingDuring$ } from 'src/app/services/loader.service'
-import { BehaviorSubject, combineLatest, from, merge, Observable, of } from 'rxjs'
-import { catchError, concatMap, delay, filter, skip, switchMap, tap } from 'rxjs/operators'
+import { BehaviorSubject, from, Observable, of } from 'rxjs'
+import { catchError, concatMap, filter, switchMap, tap } from 'rxjs/operators'
 import { Recommendation } from 'src/app/components/recommendation-button/recommendation-button.component'
 import { wizardModal } from 'src/app/components/install-wizard/install-wizard.component'
 import { WizardBaker } from 'src/app/components/install-wizard/prebaked-wizards'
@@ -13,7 +13,6 @@ import { AppModel } from 'src/app/models/app-model'
 import { initPropertySubject, peekProperties, PropertySubject } from 'src/app/util/property-subject.util'
 import { Cleanup } from 'src/app/util/cleanup'
 import { InformationPopoverComponent } from 'src/app/components/information-popover/information-popover.component'
-import { AppReleaseNotesPage } from 'src/app/modals/app-release-notes/app-release-notes.page'
 import { Emver } from 'src/app/services/emver.service'
 import { displayEmver } from 'src/app/pipes/emver.pipe'
 
@@ -189,20 +188,6 @@ export class AppAvailableShowPage extends Cleanup {
     }
   }
 
-  async presentModalReleaseNotes () {
-    const { releaseNotes, versionViewing } = peekProperties(this.$app$)
-
-    const modal = await this.modalCtrl.create({
-      component: AppReleaseNotesPage,
-      componentProps: {
-        releaseNotes,
-        version: versionViewing,
-      },
-    })
-
-    await modal.present()
-  }
-
   private fetchRecommendation (): Observable<any> {
     this.recommendation = history.state && history.state.installationRecommendation