From bb59b96e64551516f15118f914df76c0bc735713 Mon Sep 17 00:00:00 2001 From: BluJ Date: Mon, 8 May 2023 11:03:26 -0600 Subject: [PATCH] chore: Fix the test --- lib/test/configBuilder.test.ts | 18 ++++++++---------- scripts/oldSpecToBuilder.ts | 8 ++++---- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/lib/test/configBuilder.test.ts b/lib/test/configBuilder.test.ts index 8bb488b..d196742 100644 --- a/lib/test/configBuilder.test.ts +++ b/lib/test/configBuilder.test.ts @@ -44,7 +44,7 @@ describe("values", () => { name: "Testing", description: null, warning: null, - default: null, + default: false, }) const validator = value.validator validator.unsafeCast(false) @@ -239,7 +239,7 @@ describe("values", () => { name: "test", description: null, warning: null, - default: null, + default: false, }), }), ) @@ -254,7 +254,6 @@ describe("values", () => { required: { default: null }, description: null, warning: null, - default: null, }, Variants.of({ a: { @@ -264,7 +263,7 @@ describe("values", () => { name: "b", description: null, warning: null, - default: null, + default: false, }), }), }, @@ -304,7 +303,7 @@ describe("values", () => { name: "Testing", description: null, warning: null, - default: null, + default: false, })) const validator = value.validator validator.unsafeCast(false) @@ -314,7 +313,7 @@ describe("values", () => { name: "Testing", description: null, warning: null, - default: null, + default: false, }) }) test("text", async () => { @@ -507,7 +506,6 @@ describe("values", () => { required: { default: null }, description: null, warning: null, - default: null, }, Variants.of({ a: { @@ -517,7 +515,7 @@ describe("values", () => { name: "b", description: null, warning: null, - default: null, + default: false, }), }), }, @@ -528,7 +526,7 @@ describe("values", () => { name: "b", description: null, warning: null, - default: null, + default: false, }), }), }, @@ -582,7 +580,7 @@ describe("Builder List", () => { name: "test", description: null, warning: null, - default: null, + default: false, }), }), }, diff --git a/scripts/oldSpecToBuilder.ts b/scripts/oldSpecToBuilder.ts index 73a7e6c..1bbaf07 100644 --- a/scripts/oldSpecToBuilder.ts +++ b/scripts/oldSpecToBuilder.ts @@ -351,11 +351,11 @@ import { Variants } from "${startSdk}/lib/config/builder/variants" )}, warning: ${JSON.stringify(value?.spec?.tag?.warning || null)}, required: ${JSON.stringify( - !(value?.spec?.tag?.nullable || false) - ? { default: null } - : false, + // prettier-ignore + 'default' in value?.spec ? {default: value?.spec?.default} : + !!value?.spec?.tag?.nullable || false ? {default: null} : + false, )}, - default: ${JSON.stringify(value?.spec?.default || null)}, }, ${variants}) `, )