sideload wip, websockets, styling, multiple todos (#2865)

* sideload wip, websockets, styling, multiple todos

* sideload

* misc backend updates

* chore: comments

* prep for license and instructions display

* comment for Matt

* s9pk updates and 040 sdk

* fix dependency error for actions

* 0.4.0-beta.1

* beta.2

---------

Co-authored-by: Aiden McClelland <me@drbonez.dev>
Co-authored-by: waterplea <alexander@inkin.ru>
Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>

sdk/package/lib/StartSdk.ts

@@ -30,7 +30,12 @@ import { HealthCheck } from "./health/HealthCheck"
 import { checkPortListening } from "./health/checkFns/checkPortListening"
 import { checkWebUrl, runHealthScript } from "./health/checkFns"
 import { List } from "../../base/lib/actions/input/builder/list"
-import { Install, InstallFn } from "./inits/setupInstall"
+import {
+  Install,
+  InstallFn,
+  PostInstall,
+  PreInstall,
+} from "./inits/setupInstall"
 import { SetupBackupsParams, setupBackups } from "./backup/setupBackups"
 import { UninstallFn, setupUninstall } from "./inits/setupUninstall"
 import { setupMain } from "./mainFn"
@@ -571,12 +576,24 @@ export class StartSdk<Manifest extends T.SDKManifest, Store> {
       setupDependencies: setupDependencies<Manifest>,
       setupInit: setupInit<Manifest, Store>,
       /**
-       * @description Use this function to execute arbitrary logic *once*, on initial install only.
+       * @description Use this function to execute arbitrary logic *once*, on initial install *before* interfaces, actions, and dependencies are updated.
+       * @example
+       * In the this example, we initialize a config file
+       *
+       * ```
+        const preInstall = sdk.setupPreInstall(async ({ effects }) => {
+          await configFile.write(effects, { name: 'World' })
+        })
+       * ```
+       */
+      setupPreInstall: (fn: InstallFn<Manifest, Store>) => PreInstall.of(fn),
+      /**
+       * @description Use this function to execute arbitrary logic *once*, on initial install *after* interfaces, actions, and dependencies are updated.
        * @example
        * In the this example, we bootstrap our Store with a random, 16-char admin password.
        *
        * ```
-        const install = sdk.setupInstall(async ({ effects }) => {
+        const postInstall = sdk.setupPostInstall(async ({ effects }) => {
           await sdk.store.setOwn(
             effects,
             sdk.StorePath.adminPassword,
@@ -588,10 +605,7 @@ export class StartSdk<Manifest extends T.SDKManifest, Store> {
         })
        * ```
        */
-      setupInstall: (
-        fn: InstallFn<Manifest, Store>,
-        preFn?: InstallFn<Manifest, Store>,
-      ) => Install.of(fn, preFn),
+      setupPostInstall: (fn: InstallFn<Manifest, Store>) => PostInstall.of(fn),
       /**
        * @description Use this function to determine how this service will be hosted and served. The function executes on service install, service update, and inputSpec save.
        *

sdk/package/lib/inits/setupInit.ts

@@ -5,12 +5,13 @@ import { ExposedStorePaths } from "../../../base/lib/types"
 import * as T from "../../../base/lib/types"
 import { StorePath } from "../util"
 import { VersionGraph } from "../version/VersionGraph"
-import { Install } from "./setupInstall"
+import { PostInstall, PreInstall } from "./setupInstall"
 import { Uninstall } from "./setupUninstall"
 
 export function setupInit<Manifest extends T.SDKManifest, Store>(
   versions: VersionGraph<string>,
-  install: Install<Manifest, Store>,
+  preInstall: PreInstall<Manifest, Store>,
+  postInstall: PostInstall<Manifest, Store>,
   uninstall: Uninstall<Manifest, Store>,
   setServiceInterfaces: UpdateServiceInterfaces<any>,
   setDependencies: (options: {
@@ -34,7 +35,7 @@ export function setupInit<Manifest extends T.SDKManifest, Store>(
           to: versions.currentVersion(),
         })
       } else {
-        await install.install(opts)
+        await postInstall.postInstall(opts)
         await opts.effects.setDataVersion({
           version: versions.current.options.version,
         })
@@ -61,7 +62,7 @@ export function setupInit<Manifest extends T.SDKManifest, Store>(
           path: "" as StorePath,
           value: initStore,
         })
-        await install.preInstall(opts)
+        await preInstall.preInstall(opts)
       }
       await setServiceInterfaces({
         ...opts,

sdk/package/lib/inits/setupInstall.ts

@@ -4,34 +4,57 @@ export type InstallFn<Manifest extends T.SDKManifest, Store> = (opts: {
   effects: T.Effects
 }) => Promise<null | void | undefined>
 export class Install<Manifest extends T.SDKManifest, Store> {
-  private constructor(
-    readonly fn: InstallFn<Manifest, Store>,
-    readonly preFn?: InstallFn<Manifest, Store>,
-  ) {}
+  protected constructor(readonly fn: InstallFn<Manifest, Store>) {}
+}
+
+export class PreInstall<Manifest extends T.SDKManifest, Store> extends Install<
+  Manifest,
+  Store
+> {
+  private constructor(fn: InstallFn<Manifest, Store>) {
+    super(fn)
+  }
   static of<Manifest extends T.SDKManifest, Store>(
     fn: InstallFn<Manifest, Store>,
-    preFn?: InstallFn<Manifest, Store>,
   ) {
-    return new Install(fn, preFn)
+    return new PreInstall(fn)
   }
 
-  async install({ effects }: Parameters<T.ExpectedExports.packageInit>[0]) {
+  async preInstall({ effects }: Parameters<T.ExpectedExports.packageInit>[0]) {
     await this.fn({
       effects,
     })
   }
+}
 
-  async preInstall({ effects }: Parameters<T.ExpectedExports.packageInit>[0]) {
-    this.preFn &&
-      (await this.preFn({
-        effects,
-      }))
+export function setupPreInstall<Manifest extends T.SDKManifest, Store>(
+  fn: InstallFn<Manifest, Store>,
+) {
+  return PreInstall.of(fn)
+}
+
+export class PostInstall<Manifest extends T.SDKManifest, Store> extends Install<
+  Manifest,
+  Store
+> {
+  private constructor(fn: InstallFn<Manifest, Store>) {
+    super(fn)
+  }
+  static of<Manifest extends T.SDKManifest, Store>(
+    fn: InstallFn<Manifest, Store>,
+  ) {
+    return new PostInstall(fn)
+  }
+
+  async postInstall({ effects }: Parameters<T.ExpectedExports.packageInit>[0]) {
+    await this.fn({
+      effects,
+    })
   }
 }
 
-export function setupInstall<Manifest extends T.SDKManifest, Store>(
+export function setupPostInstall<Manifest extends T.SDKManifest, Store>(
   fn: InstallFn<Manifest, Store>,
-  preFn?: InstallFn<Manifest, Store>,
 ) {
-  return Install.of(fn, preFn)
+  return PostInstall.of(fn)
 }