Refactor/actions (#2733)

* store, properties, manifest

* interfaces

* init and backups

* fix init and backups

* file models

* more versions

* dependencies

* config except dynamic types

* clean up config

* remove disabled from non-dynamic vaues

* actions

* standardize example code block formats

* wip: actions refactor

Co-authored-by: Jade <Blu-J@users.noreply.github.com>

* commit types

* fix types

* update types

* update action request type

* update apis

* add description to actionrequest

* clean up imports

* revert package json

* chore: Remove the recursive to the index

* chore: Remove the other thing I was testing

* flatten action requests

* update container runtime with new config paradigm

* new actions strategy

* seems to be working

* misc backend fixes

* fix fe bugs

* only show breakages if breakages

* only show success modal if result

* don't panic on failed removal

* hide config from actions page

* polyfill autoconfig

* use metadata strategy for actions instead of prev

* misc fixes

* chore: split the sdk into 2 libs (#2736)

* follow sideload progress (#2718)

* follow sideload progress

* small bugfix

* shareReplay with no refcount false

* don't wrap sideload progress in RPCResult

* dont present toast

---------

Co-authored-by: Aiden McClelland <me@drbonez.dev>

* chore: Add the initial of the creation of the two sdk

* chore: Add in the baseDist

* chore: Add in the baseDist

* chore: Get the web and the runtime-container running

* chore: Remove the empty file

* chore: Fix it so the container-runtime works

---------

Co-authored-by: Matt Hill <MattDHill@users.noreply.github.com>
Co-authored-by: Aiden McClelland <me@drbonez.dev>

* misc fixes

* update todos

* minor clean up

* fix link script

* update node version in CI test

* fix node version syntax in ci build

* wip: fixing callbacks

* fix sdk makefile dependencies

* add support for const outside of main

* update apis

* don't panic!

* Chore: Capture weird case on rpc, and log that

* fix procedure id issue

* pass input value for dep auto config

* handle disabled and warning for actions

* chore: Fix for link not having node_modules

* sdk fixes

* fix build

* fix build

* fix build

---------

Co-authored-by: Matt Hill <mattnine@protonmail.com>
Co-authored-by: Jade <Blu-J@users.noreply.github.com>
Co-authored-by: J H <dragondef@gmail.com>
Co-authored-by: Jade <2364004+Blu-J@users.noreply.github.com>
Co-authored-by: Matt Hill <MattDHill@users.noreply.github.com>

core/models/src/clap.rs

@@ -0,0 +1,35 @@
+use std::marker::PhantomData;
+use std::str::FromStr;
+
+use rpc_toolkit::clap;
+use rpc_toolkit::clap::builder::TypedValueParser;
+
+pub struct FromStrParser<T>(PhantomData<T>);
+impl<T> FromStrParser<T> {
+    pub fn new() -> Self {
+        Self(PhantomData)
+    }
+}
+impl<T> Clone for FromStrParser<T> {
+    fn clone(&self) -> Self {
+        Self(PhantomData)
+    }
+}
+impl<T> TypedValueParser for FromStrParser<T>
+where
+    T: FromStr + Clone + Send + Sync + 'static,
+    T::Err: std::fmt::Display,
+{
+    type Value = T;
+    fn parse_ref(
+        &self,
+        _: &clap::Command,
+        _: Option<&clap::Arg>,
+        value: &std::ffi::OsStr,
+    ) -> Result<Self::Value, clap::Error> {
+        value
+            .to_string_lossy()
+            .parse()
+            .map_err(|e| clap::Error::raw(clap::error::ErrorKind::ValueValidation, e))
+    }
+}

core/models/src/id/mod.rs

@@ -11,6 +11,7 @@ mod host;
 mod image;
 mod invalid_id;
 mod package;
+mod replay;
 mod service_interface;
 mod volume;
 
@@ -20,6 +21,7 @@ pub use host::HostId;
 pub use image::ImageId;
 pub use invalid_id::InvalidId;
 pub use package::{PackageId, SYSTEM_PACKAGE_ID};
+pub use replay::ReplayId;
 pub use service_interface::ServiceInterfaceId;
 pub use volume::VolumeId;
 

core/models/src/id/replay.rs

@@ -0,0 +1,45 @@
+use std::convert::Infallible;
+use std::path::Path;
+use std::str::FromStr;
+
+use serde::{Deserialize, Serialize};
+use ts_rs::TS;
+use yasi::InternedString;
+
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, TS)]
+#[ts(type = "string")]
+pub struct ReplayId(InternedString);
+impl FromStr for ReplayId {
+    type Err = Infallible;
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        Ok(ReplayId(InternedString::intern(s)))
+    }
+}
+impl AsRef<ReplayId> for ReplayId {
+    fn as_ref(&self) -> &ReplayId {
+        self
+    }
+}
+impl std::fmt::Display for ReplayId {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "{}", &self.0)
+    }
+}
+impl AsRef<str> for ReplayId {
+    fn as_ref(&self) -> &str {
+        self.0.as_ref()
+    }
+}
+impl AsRef<Path> for ReplayId {
+    fn as_ref(&self) -> &Path {
+        self.0.as_ref()
+    }
+}
+impl<'de> Deserialize<'de> for ReplayId {
+    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
+    where
+        D: serde::de::Deserializer<'de>,
+    {
+        Ok(ReplayId(serde::Deserialize::deserialize(deserializer)?))
+    }
+}

core/models/src/id/service_interface.rs

@@ -1,9 +1,11 @@
 use std::path::Path;
+use std::str::FromStr;
 
+use rpc_toolkit::clap::builder::ValueParserFactory;
 use serde::{Deserialize, Deserializer, Serialize};
 use ts_rs::TS;
 
-use crate::Id;
+use crate::{FromStrParser, Id};
 
 #[derive(Clone, Debug, Default, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, TS)]
 #[ts(export, type = "string")]
@@ -59,3 +61,15 @@ impl sqlx::Type<sqlx::Postgres> for ServiceInterfaceId {
         <&str as sqlx::Type<sqlx::Postgres>>::compatible(ty)
     }
 }
+impl FromStr for ServiceInterfaceId {
+    type Err = <Id as FromStr>::Err;
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        Id::from_str(s).map(Self)
+    }
+}
+impl ValueParserFactory for ServiceInterfaceId {
+    type Parser = FromStrParser<Self>;
+    fn value_parser() -> Self::Parser {
+        FromStrParser::new()
+    }
+}

core/models/src/lib.rs

@@ -1,3 +1,4 @@
+mod clap;
 mod data_url;
 mod errors;
 mod id;
@@ -5,6 +6,7 @@ mod mime;
 mod procedure_name;
 mod version;
 
+pub use clap::*;
 pub use data_url::*;
 pub use errors::*;
 pub use id::*;

core/models/src/procedure_name.rs

@@ -1,6 +1,6 @@
 use serde::{Deserialize, Serialize};
 
-use crate::{ActionId, PackageId};
+use crate::ActionId;
 
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub enum ProcedureName {
@@ -9,30 +9,24 @@ pub enum ProcedureName {
     CreateBackup,
     Properties,
     RestoreBackup,
-    ActionMetadata,
+    GetActionInput(ActionId),
     RunAction(ActionId),
-    GetAction(ActionId),
-    QueryDependency(PackageId),
-    UpdateDependency(PackageId),
-    Init,
-    Uninit,
+    PackageInit,
+    PackageUninit,
 }
 
 impl ProcedureName {
     pub fn js_function_name(&self) -> String {
         match self {
-            ProcedureName::Init => "/init".to_string(),
-            ProcedureName::Uninit => "/uninit".to_string(),
+            ProcedureName::PackageInit => "/packageInit".to_string(),
+            ProcedureName::PackageUninit => "/packageUninit".to_string(),
             ProcedureName::SetConfig => "/config/set".to_string(),
             ProcedureName::GetConfig => "/config/get".to_string(),
             ProcedureName::CreateBackup => "/backup/create".to_string(),
             ProcedureName::Properties => "/properties".to_string(),
             ProcedureName::RestoreBackup => "/backup/restore".to_string(),
-            ProcedureName::ActionMetadata => "/actions/metadata".to_string(),
             ProcedureName::RunAction(id) => format!("/actions/{}/run", id),
-            ProcedureName::GetAction(id) => format!("/actions/{}/get", id),
-            ProcedureName::QueryDependency(id) => format!("/dependencies/{}/query", id),
-            ProcedureName::UpdateDependency(id) => format!("/dependencies/{}/update", id),
+            ProcedureName::GetActionInput(id) => format!("/actions/{}/getInput", id),
         }
     }
 }