ui: no mutations, less hacky

ui/src/app/modals/os-welcome/os-welcome.page.ts

@@ -28,6 +28,8 @@ export class OSWelcomePage {
         .then(() => this.apiService.acknowledgeOSWelcome(this.config.version))
         .catch(console.error)
 
-    return this.modalCtrl.dismiss({ autoCheckUpdates: this.autoCheckUpdates })
+    // return false to skip subsequent alert modals
+    // return true to show subsequent alert modals
+    return this.modalCtrl.dismiss(this.autoCheckUpdates)
   }
 }

ui/src/app/services/startup-alerts.notifier.ts

@@ -39,7 +39,7 @@ export class StartupAlertsNotifier {
         c.hasRun = true
         if (!checkRes) return
         const displayRes = await previousDisplay
-        if (c.shouldRun(server) && !!displayRes) return c.display(checkRes)
+        if (displayRes) return c.display(checkRes)
       }, Promise.resolve(true))
   }
 
@@ -103,8 +103,7 @@ export class StartupAlertsNotifier {
 
       await modal.present()
       modal.onWillDismiss().then(res => {
-        s = Object.assign(s, res.data)
-        return resolve(true)
+        return resolve(res.data)
       })
     })
   }