fixes #3150

web/projects/setup-wizard/src/app/pages/drives.page.ts

@@ -4,8 +4,16 @@ import {
   HostListener,
   inject,
 } from '@angular/core'
+import {
+  AbstractControl,
+  FormControl,
+  FormGroup,
+  ReactiveFormsModule,
+  ValidatorFn,
+  Validators,
+} from '@angular/forms'
 import { Router } from '@angular/router'
-import { FormsModule } from '@angular/forms'
+import { WA_IS_MOBILE } from '@ng-web-apis/platform'
 import {
   DialogService,
   DiskInfo,
@@ -14,13 +22,14 @@ import {
   i18nPipe,
   toGuid,
 } from '@start9labs/shared'
-import { WA_IS_MOBILE } from '@ng-web-apis/platform'
+import { TuiMapperPipe, TuiValidator } from '@taiga-ui/cdk'
 import {
   TuiButton,
+  TuiError,
   TuiIcon,
   TuiLoader,
-  TuiInput,
   TuiNotification,
+  TUI_VALIDATION_ERRORS,
   TuiTitle,
 } from '@taiga-ui/core'
 import {
@@ -29,49 +38,55 @@ import {
   TuiSelect,
   TuiTooltip,
 } from '@taiga-ui/kit'
-import { TuiCardLarge, TuiHeader } from '@taiga-ui/layout'
-import { PolymorpheusComponent } from '@taiga-ui/polymorpheus'
-import { filter, Subscription } from 'rxjs'
+import { TuiCardLarge, TuiForm, TuiHeader } from '@taiga-ui/layout'
+import { distinctUntilChanged, filter, Subscription } from 'rxjs'
+import { PRESERVE_OVERWRITE } from '../components/preserve-overwrite.dialog'
 import { ApiService } from '../services/api.service'
 import { StateService } from '../services/state.service'
-import { PRESERVE_OVERWRITE } from '../components/preserve-overwrite.dialog'
 
 @Component({
   template: `
     @if (!shuttingDown) {
-      <section tuiCardLarge="compact">
-        <header tuiHeader>
-          <h2 tuiTitle>{{ 'Select Drives' | i18n }}</h2>
-        </header>
-
-        @if (loading) {
+      @if (loading) {
+        <section tuiCardLarge="compact">
+          <header tuiHeader>
+            <h2 tuiTitle>{{ 'Select Drives' | i18n }}</h2>
+          </header>
           <tui-loader />
-        } @else if (drives.length === 0) {
+        </section>
+      } @else if (drives.length === 0) {
+        <section tuiCardLarge="compact">
+          <header tuiHeader>
+            <h2 tuiTitle>{{ 'Select Drives' | i18n }}</h2>
+          </header>
           <p tuiNotification size="m" appearance="warning">
             {{
               'No drives found. Please connect a drive and click Refresh.'
                 | i18n
             }}
           </p>
-        } @else {
-          <tui-textfield
-            [stringify]="stringify"
-            [disabledItemHandler]="osDisabled"
-          >
+          <footer>
+            <button tuiButton appearance="secondary" (click)="refresh()">
+              {{ 'Refresh' | i18n }}
+            </button>
+          </footer>
+        </section>
+      } @else {
+        <form tuiCardLarge="compact" tuiForm [formGroup]="form">
+          <header tuiHeader>
+            <h2 tuiTitle>{{ 'Select Drives' | i18n }}</h2>
+          </header>
+
+          <tui-textfield [stringify]="stringify">
             <label tuiLabel>{{ 'OS Drive' | i18n }}</label>
             @if (mobile) {
               <select
                 tuiSelect
-                [ngModel]="selectedOsDrive"
-                (ngModelChange)="onOsDriveChange($event)"
+                formControlName="osDrive"
                 [items]="drives"
               ></select>
             } @else {
-              <input
-                tuiSelect
-                [ngModel]="selectedOsDrive"
-                (ngModelChange)="onOsDriveChange($event)"
-              />
+              <input tuiSelect formControlName="osDrive" />
             }
             @if (!mobile) {
               <tui-data-list-wrapper
@@ -82,24 +97,28 @@ import { PRESERVE_OVERWRITE } from '../components/preserve-overwrite.dialog'
             }
             <tui-icon [tuiTooltip]="osDriveTooltip" />
           </tui-textfield>
+          @if (form.controls.osDrive.touched && form.controls.osDrive.invalid) {
+            <tui-error formControlName="osDrive" />
+          }
 
-          <tui-textfield
-            [stringify]="stringify"
-            [disabledItemHandler]="dataDisabled"
-          >
+          <tui-textfield [stringify]="stringify">
             <label tuiLabel>{{ 'Data Drive' | i18n }}</label>
             @if (mobile) {
               <select
                 tuiSelect
-                [(ngModel)]="selectedDataDrive"
-                (ngModelChange)="onDataDriveChange($event)"
+                formControlName="dataDrive"
                 [items]="drives"
+                [tuiValidator]="
+                  form.controls.osDrive.value | tuiMapper: dataValidator
+                "
               ></select>
             } @else {
               <input
                 tuiSelect
-                [(ngModel)]="selectedDataDrive"
-                (ngModelChange)="onDataDriveChange($event)"
+                formControlName="dataDrive"
+                [tuiValidator]="
+                  form.controls.osDrive.value | tuiMapper: dataValidator
+                "
               />
             }
             @if (!mobile) {
@@ -117,6 +136,11 @@ import { PRESERVE_OVERWRITE } from '../components/preserve-overwrite.dialog'
             }
             <tui-icon [tuiTooltip]="dataDriveTooltip" />
           </tui-textfield>
+          @if (
+            form.controls.dataDrive.touched && form.controls.dataDrive.invalid
+          ) {
+            <tui-error formControlName="dataDrive" />
+          }
 
           <ng-template #driveContent let-drive>
             <span tuiTitle>
@@ -126,24 +150,14 @@ import { PRESERVE_OVERWRITE } from '../components/preserve-overwrite.dialog'
               </span>
             </span>
           </ng-template>
-        }
 
-        <footer>
-          @if (drives.length === 0) {
-            <button tuiButton appearance="secondary" (click)="refresh()">
-              {{ 'Refresh' | i18n }}
-            </button>
-          } @else {
-            <button
-              tuiButton
-              [disabled]="!selectedOsDrive || !selectedDataDrive"
-              (click)="continue()"
-            >
+          <footer>
+            <button tuiButton [disabled]="form.invalid" (click)="continue()">
               {{ 'Continue' | i18n }}
             </button>
-          }
-        </footer>
-      </section>
+          </footer>
+        </form>
+      }
     }
   `,
   styles: `
@@ -152,20 +166,34 @@ import { PRESERVE_OVERWRITE } from '../components/preserve-overwrite.dialog'
     }
   `,
   imports: [
-    FormsModule,
+    ReactiveFormsModule,
     TuiCardLarge,
+    TuiForm,
     TuiButton,
+    TuiError,
     TuiIcon,
     TuiLoader,
-    TuiInput,
     TuiNotification,
     TuiSelect,
     TuiDataListWrapper,
     TuiTooltip,
+    TuiValidator,
+    TuiMapperPipe,
     TuiHeader,
     TuiTitle,
     i18nPipe,
   ],
+  providers: [
+    {
+      provide: TUI_VALIDATION_ERRORS,
+      useFactory: () => {
+        const i18n = inject(i18nPipe)
+        return {
+          required: i18n.transform('Required'),
+        }
+      },
+    },
+  ],
 })
 export default class DrivesPage {
   private readonly api = inject(ApiService)
@@ -188,29 +216,63 @@ export default class DrivesPage {
   }
 
   readonly osDriveTooltip = this.i18n.transform(
-    'The drive where the StartOS operating system will be installed.',
+    'The drive where the StartOS operating system will be installed. Minimum 18 GB.',
   )
   readonly dataDriveTooltip = this.i18n.transform(
-    'The drive where your StartOS data (services, settings, etc.) will be stored. This can be the same as the OS drive or a separate drive.',
+    'The drive where your StartOS data (services, settings, etc.) will be stored. This can be the same as the OS drive or a separate drive. Minimum 20 GB, or 38 GB if using a single drive for both OS and data.',
   )
 
   private readonly MIN_OS = 18 * 2 ** 30 // 18 GiB
   private readonly MIN_DATA = 20 * 2 ** 30 // 20 GiB
   private readonly MIN_BOTH = 38 * 2 ** 30 // 38 GiB
 
+  private readonly osCapacityValidator: ValidatorFn = ({
+    value,
+  }: AbstractControl) => {
+    if (!value) return null
+    return value.capacity < this.MIN_OS
+      ? {
+          tooSmallOs: this.i18n.transform('OS drive must be at least 18 GB'),
+        }
+      : null
+  }
+
+  readonly form = new FormGroup({
+    osDrive: new FormControl<DiskInfo | null>(null, [
+      Validators.required,
+      this.osCapacityValidator,
+    ]),
+    dataDrive: new FormControl<DiskInfo | null>(null, [Validators.required]),
+  })
+
+  readonly dataValidator =
+    (osDrive: DiskInfo | null): ValidatorFn =>
+    ({ value }: AbstractControl) => {
+      if (!value) return null
+      const sameAsOs = osDrive && value.logicalname === osDrive.logicalname
+      const min = sameAsOs ? this.MIN_BOTH : this.MIN_DATA
+      if (value.capacity < min) {
+        return sameAsOs
+          ? {
+              tooSmallBoth: this.i18n.transform(
+                'OS + data combined require at least 38 GB',
+              ),
+            }
+          : {
+              tooSmallData: this.i18n.transform(
+                'Data drive must be at least 20 GB',
+              ),
+            }
+      }
+      return null
+    }
+
   drives: DiskInfo[] = []
   loading = true
   shuttingDown = false
   private dialogSub?: Subscription
-  selectedOsDrive: DiskInfo | null = null
-  selectedDataDrive: DiskInfo | null = null
   preserveData: boolean | null = null
 
-  readonly osDisabled = (drive: DiskInfo): boolean =>
-    drive.capacity < this.MIN_OS
-
-  dataDisabled = (drive: DiskInfo): boolean => drive.capacity < this.MIN_DATA
-
   readonly driveName = (drive: DiskInfo): string =>
     [drive.vendor, drive.model].filter(Boolean).join(' ') ||
     this.i18n.transform('Unknown Drive')
@@ -228,51 +290,40 @@ export default class DrivesPage {
 
   async ngOnInit() {
     await this.loadDrives()
+
+    this.form.controls.osDrive.valueChanges.subscribe(drive => {
+      if (drive) {
+        this.form.controls.osDrive.markAsTouched()
+      }
+    })
+
+    this.form.controls.dataDrive.valueChanges
+      .pipe(distinctUntilChanged())
+      .subscribe(drive => {
+        this.preserveData = null
+        if (drive) {
+          this.form.controls.dataDrive.markAsTouched()
+          if (toGuid(drive)) {
+            this.showPreserveOverwriteDialog()
+          }
+        }
+      })
   }
 
   async refresh() {
     this.loading = true
-    this.selectedOsDrive = null
-    this.selectedDataDrive = null
+    this.form.reset()
     this.preserveData = null
     await this.loadDrives()
   }
 
-  onOsDriveChange(osDrive: DiskInfo | null) {
-    this.selectedOsDrive = osDrive
-    this.dataDisabled = (drive: DiskInfo) => {
-      if (osDrive && drive.logicalname === osDrive.logicalname) {
-        return drive.capacity < this.MIN_BOTH
-      }
-      return drive.capacity < this.MIN_DATA
-    }
-
-    // Clear data drive if it's now invalid
-    if (this.selectedDataDrive && this.dataDisabled(this.selectedDataDrive)) {
-      this.selectedDataDrive = null
-      this.preserveData = null
-    }
-  }
-
-  onDataDriveChange(drive: DiskInfo | null) {
-    this.preserveData = null
-
-    if (!drive) {
-      return
-    }
-
-    const hasStartOSData = !!toGuid(drive)
-    if (hasStartOSData) {
-      this.showPreserveOverwriteDialog()
-    }
-  }
-
   continue() {
-    if (!this.selectedOsDrive || !this.selectedDataDrive) return
+    const osDrive = this.form.controls.osDrive.value
+    const dataDrive = this.form.controls.dataDrive.value
+    if (!osDrive || !dataDrive) return
 
-    const sameDevice =
-      this.selectedOsDrive.logicalname === this.selectedDataDrive.logicalname
-    const dataHasStartOS = !!toGuid(this.selectedDataDrive)
+    const sameDevice = osDrive.logicalname === dataDrive.logicalname
+    const dataHasStartOS = !!toGuid(dataDrive)
 
     // Scenario 1: Same drive, has StartOS data, preserving → no warning
     if (sameDevice && dataHasStartOS && this.preserveData) {
@@ -292,7 +343,7 @@ export default class DrivesPage {
 
   private showPreserveOverwriteDialog() {
     let selectionMade = false
-    const drive = this.selectedDataDrive
+    const drive = this.form.controls.dataDrive.value
     const filesystem =
       drive?.filesystem ||
       drive?.partitions.find(p => p.guid)?.filesystem ||
@@ -304,20 +355,20 @@ export default class DrivesPage {
         data: { isExt4 },
       })
       .subscribe({
-      next: preserve => {
-        selectionMade = true
-        this.preserveData = preserve
-        this.cdr.markForCheck()
-      },
-      complete: () => {
-        if (!selectionMade) {
-          // Dialog was dismissed without selection - clear the data drive
-          this.selectedDataDrive = null
-          this.preserveData = null
+        next: preserve => {
+          selectionMade = true
+          this.preserveData = preserve
           this.cdr.markForCheck()
-        }
-      },
-    })
+        },
+        complete: () => {
+          if (!selectionMade) {
+            // Dialog was dismissed without selection - clear the data drive
+            this.form.controls.dataDrive.reset()
+            this.preserveData = null
+            this.cdr.markForCheck()
+          }
+        },
+      })
   }
 
   private showOsDriveWarning() {
@@ -360,13 +411,15 @@ export default class DrivesPage {
   }
 
   private async installOs(wipe: boolean) {
+    const osDrive = this.form.controls.osDrive.value!
+    const dataDrive = this.form.controls.dataDrive.value!
     const loader = this.loader.open('Installing StartOS').subscribe()
 
     try {
       const result = await this.api.installOs({
-        osDrive: this.selectedOsDrive!.logicalname,
+        osDrive: osDrive.logicalname,
         dataDrive: {
-          logicalname: this.selectedDataDrive!.logicalname,
+          logicalname: dataDrive.logicalname,
           wipe,
         },
       })

web/projects/shared/src/i18n/dictionaries/de.ts

@@ -628,8 +628,8 @@ export default {
   697: 'Geben Sie das Passwort ein, das zum Verschlüsseln dieses Backups verwendet wurde.',
   698: 'Mehrere Backups gefunden. Wählen Sie aus, welches wiederhergestellt werden soll.',
   699: 'Backups',
-  700: 'Das Laufwerk, auf dem das StartOS-Betriebssystem installiert wird.',
-  701: 'Das Laufwerk, auf dem Ihre StartOS-Daten (Dienste, Einstellungen usw.) gespeichert werden. Dies kann dasselbe wie das OS-Laufwerk oder ein separates Laufwerk sein.',
+  700: 'Das Laufwerk, auf dem das StartOS-Betriebssystem installiert wird. Mindestens 18 GB.',
+  701: 'Das Laufwerk, auf dem Ihre StartOS-Daten (Dienste, Einstellungen usw.) gespeichert werden. Dies kann dasselbe wie das OS-Laufwerk oder ein separates Laufwerk sein. Mindestens 20 GB, oder 38 GB bei Verwendung eines einzelnen Laufwerks für OS und Daten.',
   702: 'Versuchen Sie nach der Datenübertragung von diesem Laufwerk nicht, erneut als Start9-Server davon zu booten. Dies kann zu Fehlfunktionen von Diensten, Datenbeschädigung oder Geldverlust führen.',
   703: 'Muss mindestens 12 Zeichen lang sein',
   704: 'Darf höchstens 64 Zeichen lang sein',
@@ -724,4 +724,7 @@ export default {
   808: 'Hostname geändert, Neustart damit installierte Dienste die neue Adresse verwenden',
   809: 'Sprache geändert, Neustart damit installierte Dienste die neue Sprache verwenden',
   810: 'Kioskmodus geändert, Neustart zum Anwenden',
+  811: 'OS-Laufwerk muss mindestens 18 GB groß sein',
+  812: 'Datenlaufwerk muss mindestens 20 GB groß sein',
+  813: 'OS + Daten zusammen erfordern mindestens 38 GB',
 } satisfies i18n

web/projects/shared/src/i18n/dictionaries/en.ts

@@ -628,8 +628,8 @@ export const ENGLISH: Record<string, number> = {
   'Enter the password that was used to encrypt this backup.': 697,
   'Multiple backups found. Select which one to restore.': 698,
   'Backups': 699,
-  'The drive where the StartOS operating system will be installed.': 700,
-  'The drive where your StartOS data (services, settings, etc.) will be stored. This can be the same as the OS drive or a separate drive.': 701,
+  'The drive where the StartOS operating system will be installed. Minimum 18 GB.': 700,
+  'The drive where your StartOS data (services, settings, etc.) will be stored. This can be the same as the OS drive or a separate drive. Minimum 20 GB, or 38 GB if using a single drive for both OS and data.': 701,
   'After transferring data from this drive, do not attempt to boot into it again as a Start9 Server. This may result in services malfunctioning, data corruption, or loss of funds.': 702,
   'Must be 12 characters or greater': 703,
   'Must be 64 character or less': 704,
@@ -725,4 +725,7 @@ export const ENGLISH: Record<string, number> = {
   'Hostname changed, restart for installed services to use the new address': 808,
   'Language changed, restart for installed services to use the new language': 809,
   'Kiosk mode changed, restart to apply': 810,
+  'OS drive must be at least 18 GB': 811,
+  'Data drive must be at least 20 GB': 812,
+  'OS + data combined require at least 38 GB': 813,
 }

web/projects/shared/src/i18n/dictionaries/es.ts

@@ -628,8 +628,8 @@ export default {
   697: 'Introduzca la contraseña que se utilizó para cifrar esta copia de seguridad.',
   698: 'Se encontraron varias copias de seguridad. Seleccione cuál restaurar.',
   699: 'Copias de seguridad',
-  700: 'La unidad donde se instalará el sistema operativo StartOS.',
-  701: 'La unidad donde se almacenarán sus datos de StartOS (servicios, ajustes, etc.). Puede ser la misma que la unidad del sistema operativo o una unidad separada.',
+  700: 'La unidad donde se instalará el sistema operativo StartOS. Mínimo 18 GB.',
+  701: 'La unidad donde se almacenarán sus datos de StartOS (servicios, ajustes, etc.). Puede ser la misma que la unidad del sistema operativo o una unidad separada. Mínimo 20 GB, o 38 GB si se usa una sola unidad para el sistema operativo y los datos.',
   702: 'Después de transferir datos desde esta unidad, no intente arrancar desde ella nuevamente como un servidor Start9. Esto puede provocar fallos en los servicios, corrupción de datos o pérdida de fondos.',
   703: 'Debe tener 12 caracteres o más',
   704: 'Debe tener 64 caracteres o menos',
@@ -724,4 +724,7 @@ export default {
   808: 'Nombre de host cambiado, reiniciar para que los servicios instalados usen la nueva dirección',
   809: 'Idioma cambiado, reiniciar para que los servicios instalados usen el nuevo idioma',
   810: 'Modo kiosco cambiado, reiniciar para aplicar',
+  811: 'La unidad del SO debe tener al menos 18 GB',
+  812: 'La unidad de datos debe tener al menos 20 GB',
+  813: 'SO + datos combinados requieren al menos 38 GB',
 } satisfies i18n

web/projects/shared/src/i18n/dictionaries/fr.ts

@@ -628,8 +628,8 @@ export default {
   697: 'Saisissez le mot de passe utilisé pour chiffrer cette sauvegarde.',
   698: 'Plusieurs sauvegardes trouvées. Sélectionnez celle à restaurer.',
   699: 'Sauvegardes',
-  700: 'Le disque sur lequel le système d’exploitation StartOS sera installé.',
-  701: 'Le disque sur lequel vos données StartOS (services, paramètres, etc.) seront stockées. Il peut s’agir du même disque que le système ou d’un disque séparé.',
+  700: 'Le disque sur lequel le système d’exploitation StartOS sera installé. Minimum 18 Go.',
+  701: 'Le disque sur lequel vos données StartOS (services, paramètres, etc.) seront stockées. Il peut s’agir du même disque que le système ou d’un disque séparé. Minimum 20 Go, ou 38 Go si un seul disque est utilisé pour le système et les données.',
   702: 'Après le transfert des données depuis ce disque, n’essayez pas de démarrer dessus à nouveau en tant que serveur Start9. Cela peut entraîner des dysfonctionnements des services, une corruption des données ou une perte de fonds.',
   703: 'Doit comporter au moins 12 caractères',
   704: 'Doit comporter au maximum 64 caractères',
@@ -724,4 +724,7 @@ export default {
   808: "Nom d'hôte modifié, redémarrer pour que les services installés utilisent la nouvelle adresse",
   809: 'Langue modifiée, redémarrer pour que les services installés utilisent la nouvelle langue',
   810: 'Mode kiosque modifié, redémarrer pour appliquer',
+  811: 'Le disque système doit faire au moins 18 Go',
+  812: 'Le disque de données doit faire au moins 20 Go',
+  813: 'Système + données combinés nécessitent au moins 38 Go',
 } satisfies i18n

web/projects/shared/src/i18n/dictionaries/pl.ts

@@ -628,8 +628,8 @@ export default {
   697: 'Wprowadź hasło użyte do zaszyfrowania tej kopii zapasowej.',
   698: 'Znaleziono wiele kopii zapasowych. Wybierz, którą przywrócić.',
   699: 'Kopie zapasowe',
-  700: 'Dysk, na którym zostanie zainstalowany system operacyjny StartOS.',
-  701: 'Dysk, na którym będą przechowywane dane StartOS (usługi, ustawienia itp.). Może to być ten sam dysk co systemowy lub oddzielny dysk.',
+  700: 'Dysk, na którym zostanie zainstalowany system operacyjny StartOS. Minimum 18 GB.',
+  701: 'Dysk, na którym będą przechowywane dane StartOS (usługi, ustawienia itp.). Może to być ten sam dysk co systemowy lub oddzielny dysk. Minimum 20 GB lub 38 GB w przypadku jednego dysku na system i dane.',
   702: 'Po przeniesieniu danych z tego dysku nie próbuj ponownie uruchamiać z niego systemu jako serwer Start9. Może to spowodować nieprawidłowe działanie usług, uszkodzenie danych lub utratę środków.',
   703: 'Musi mieć co najmniej 12 znaków',
   704: 'Musi mieć maksymalnie 64 znaki',
@@ -724,4 +724,7 @@ export default {
   808: 'Nazwa hosta zmieniona, uruchom ponownie, aby zainstalowane usługi używały nowego adresu',
   809: 'Język zmieniony, uruchom ponownie, aby zainstalowane usługi używały nowego języka',
   810: 'Tryb kiosku zmieniony, uruchom ponownie, aby zastosować',
+  811: 'Dysk systemowy musi mieć co najmniej 18 GB',
+  812: 'Dysk danych musi mieć co najmniej 20 GB',
+  813: 'System + dane łącznie wymagają co najmniej 38 GB',
 } satisfies i18n