From 9c6aaa64b84069ea995f07f287214586bd03dd84 Mon Sep 17 00:00:00 2001
From: Matt Hill <matthewonthemoon@gmail.com>
Date: Fri, 3 Sep 2021 14:24:27 -0600
Subject: [PATCH] noreferrer everywhere

---
 ui/src/app/app.component.ts                               | 4 ++--
 ui/src/app/modals/markdown/markdown.page.ts               | 8 ++++++++
 .../apps-routes/app-interfaces/app-interfaces.page.ts     | 2 +-
 ui/src/app/pages/apps-routes/app-list/app-list.page.ts    | 2 +-
 ui/src/app/pages/apps-routes/app-show/app-show.page.ts    | 4 ++--
 ui/src/app/pages/login/login.page.html                    | 2 +-
 ui/src/app/pages/login/login.page.ts                      | 2 +-
 .../marketplace-show/marketplace-show.page.html           | 6 +++---
 ui/src/app/pages/server-routes/lan/lan.page.html          | 2 +-
 .../security-routes/ssh-keys/ssh-keys.page.html           | 2 +-
 ui/src/app/pages/server-routes/wifi/wifi.page.html        | 2 +-
 ui/src/app/services/error-toast.service.ts                | 2 +-
 12 files changed, 23 insertions(+), 15 deletions(-)

diff --git a/ui/src/app/app.component.ts b/ui/src/app/app.component.ts
index 5f72db6e0..06608c4e9 100644
--- a/ui/src/app/app.component.ts
+++ b/ui/src/app/app.component.ts
@@ -154,7 +154,7 @@ export class AppComponent {
     } else {
       url = 'https://start9.com'
     }
-    window.open(url, '_blank')
+    window.open(url, '_blank', 'noreferrer')
   }
 
   async presentAlertLogout () {
@@ -347,7 +347,7 @@ export class AppComponent {
           side: 'end',
           text: 'View solutions',
           handler: () => {
-            window.open(link, '_blank')
+            window.open(link, '_blank', 'noreferrer')
             return false
           },
         },
diff --git a/ui/src/app/modals/markdown/markdown.page.ts b/ui/src/app/modals/markdown/markdown.page.ts
index c4983f252..f281bcba6 100644
--- a/ui/src/app/modals/markdown/markdown.page.ts
+++ b/ui/src/app/modals/markdown/markdown.page.ts
@@ -23,6 +23,14 @@ export class MarkdownPage {
   async ngOnInit () {
     try {
       this.content = await this.embassyApi.getStatic(this.contentUrl)
+      const links = document.links
+      for (let i = 0, linksLength = links.length; i < linksLength; i++) {
+        if (links[i].hostname != window.location.hostname) {
+          links[i].target = '_blank'
+          links[i].setAttribute('rel', 'noreferrer')
+          links[i].className += ' externalLink'
+        }
+      }
     } catch (e) {
       this.errToast.present(e)
     } finally {
diff --git a/ui/src/app/pages/apps-routes/app-interfaces/app-interfaces.page.ts b/ui/src/app/pages/apps-routes/app-interfaces/app-interfaces.page.ts
index 2667985cc..21411da2a 100644
--- a/ui/src/app/pages/apps-routes/app-interfaces/app-interfaces.page.ts
+++ b/ui/src/app/pages/apps-routes/app-interfaces/app-interfaces.page.ts
@@ -79,7 +79,7 @@ export class AppInterfacesItemComponent {
   ) { }
 
   launch (url: string): void {
-    window.open(url, '_blank')
+    window.open(url, '_blank', 'noreferrer')
   }
 
   async copy (address: string): Promise<void> {
diff --git a/ui/src/app/pages/apps-routes/app-list/app-list.page.ts b/ui/src/app/pages/apps-routes/app-list/app-list.page.ts
index ad6c0509d..e09f7c072 100644
--- a/ui/src/app/pages/apps-routes/app-list/app-list.page.ts
+++ b/ui/src/app/pages/apps-routes/app-list/app-list.page.ts
@@ -115,7 +115,7 @@ export class AppListPage {
   launchUi (pkg: PackageDataEntry, event: Event): void {
     event.preventDefault()
     event.stopPropagation()
-    window.open(this.config.launchableURL(pkg), '_blank')
+    window.open(this.config.launchableURL(pkg), '_blank', 'noreferrer')
   }
 
   asIsOrder () {
diff --git a/ui/src/app/pages/apps-routes/app-show/app-show.page.ts b/ui/src/app/pages/apps-routes/app-show/app-show.page.ts
index bd36f9a5f..fdfd83481 100644
--- a/ui/src/app/pages/apps-routes/app-show/app-show.page.ts
+++ b/ui/src/app/pages/apps-routes/app-show/app-show.page.ts
@@ -79,7 +79,7 @@ export class AppShowPage {
   }
 
   launchUi (): void {
-    window.open(this.config.launchableURL(this.pkg), '_blank')
+    window.open(this.config.launchableURL(this.pkg), '_blank', 'noreferrer')
   }
 
   async stop (): Promise<void> {
@@ -124,7 +124,7 @@ export class AppShowPage {
   async donate (): Promise<void> {
     const url = this.pkg.manifest['donation-url']
     if (url) {
-      window.open(url, '_blank')
+      window.open(url, '_blank', 'noreferrer')
     } else {
       const alert = await this.alertCtrl.create({
         header: 'Not Accepting Donations',
diff --git a/ui/src/app/pages/login/login.page.html b/ui/src/app/pages/login/login.page.html
index 385704263..50f69a97b 100644
--- a/ui/src/app/pages/login/login.page.html
+++ b/ui/src/app/pages/login/login.page.html
@@ -23,7 +23,7 @@
                     <ion-icon slot="icon-only" [name]="unmasked ? 'eye-off-outline' : 'eye-outline'" size="small"></ion-icon>
                   </ion-button>
                 </ion-item>
-                <p *ngIf="error" style="text-align: left; padding-top: 4px"><ion-text color="danger">{{ error }}</ion-text></p>
+                <p style="text-align: left; padding-top: 4px"><ion-text color="danger">{{ error }}</ion-text></p>
               </ion-item-group>
               <ion-button class="login-button" type="submit" expand="block">
                 <span style="font-size: larger; font-weight: bold;">Log In</span>
diff --git a/ui/src/app/pages/login/login.page.ts b/ui/src/app/pages/login/login.page.ts
index 14c2ceca3..28119c0c5 100644
--- a/ui/src/app/pages/login/login.page.ts
+++ b/ui/src/app/pages/login/login.page.ts
@@ -48,7 +48,7 @@ export class LoginPage {
       await this.authService.login(this.password)
       this.password = ''
     } catch (e) {
-      this.error = e.message
+      this.error = e.code === 34 ? 'Invalid Password' : e.message
     } finally {
       this.loader.dismiss()
     }
diff --git a/ui/src/app/pages/marketplace-routes/marketplace-show/marketplace-show.page.html b/ui/src/app/pages/marketplace-routes/marketplace-show/marketplace-show.page.html
index 7b82dca66..e53111275 100644
--- a/ui/src/app/pages/marketplace-routes/marketplace-show/marketplace-show.page.html
+++ b/ui/src/app/pages/marketplace-routes/marketplace-show/marketplace-show.page.html
@@ -165,21 +165,21 @@
             </ion-col>
             <ion-col sizeSm="12" sizeMd="6">
               <ion-item-group>
-                <ion-item [href]="pkg.manifest['upstream-repo']" target="_blank" detail="false">
+                <ion-item [href]="pkg.manifest['upstream-repo']" target="_blank" rel="noreferrer" detail="false">
                   <ion-label>
                     <h2>Source Repository</h2>
                     <p>{{ pkg.manifest['upstream-repo'] }}</p>
                   </ion-label>
                   <ion-icon slot="end" name="open-outline"></ion-icon>
                 </ion-item>
-                <ion-item [href]="pkg.manifest['wrapper-repo']" target="_blank" detail="false">
+                <ion-item [href]="pkg.manifest['wrapper-repo']" target="_blank" rel="noreferrer" detail="false">
                   <ion-label>
                     <h2>Wrapper Repository</h2>
                     <p>{{ pkg.manifest['wrapper-repo'] }}</p>
                   </ion-label>
                   <ion-icon slot="end" name="open-outline"></ion-icon>
                 </ion-item>
-                <ion-item [href]="pkg.manifest['support-site']" target="_blank" detail="false">
+                <ion-item [href]="pkg.manifest['support-site']" target="_blank" rel="noreferrer" detail="false">
                   <ion-label>
                     <h2>Support Site</h2>
                     <p>{{ pkg.manifest['support-site'] }}</p>
diff --git a/ui/src/app/pages/server-routes/lan/lan.page.html b/ui/src/app/pages/server-routes/lan/lan.page.html
index 0bfccc02e..3b73d1c57 100644
--- a/ui/src/app/pages/server-routes/lan/lan.page.html
+++ b/ui/src/app/pages/server-routes/lan/lan.page.html
@@ -15,7 +15,7 @@
       <ion-label>
         <h2>
           Connecting to your Embassy over LAN is fast and a great fallback in case the Tor network is experiencing issues.
-          <a href="https://docs.start9.com/user-manual/general/lan-setup" target="_blank">View instructions</a>
+          <a href="https://docs.start9.com/user-manual/general/lan-setup" target="_blank" rel="noreferrer">View instructions</a>
         </h2>
         <ng-container *ngIf="lanDisabled">
           <br />
diff --git a/ui/src/app/pages/server-routes/security-routes/ssh-keys/ssh-keys.page.html b/ui/src/app/pages/server-routes/security-routes/ssh-keys/ssh-keys.page.html
index d14f1ca69..a79c14590 100644
--- a/ui/src/app/pages/server-routes/security-routes/ssh-keys/ssh-keys.page.html
+++ b/ui/src/app/pages/server-routes/security-routes/ssh-keys/ssh-keys.page.html
@@ -15,7 +15,7 @@
       <ion-label>
         <h2>
           Adding SSH keys to your Embassy is useful for command line access, as well as for debugging purposes.
-          <a [href]="docsUrl" target="_blank">View instructions</a>
+          <a [href]="docsUrl" target="_blank" rel="noreferrer">View instructions</a>
         </h2>
       </ion-label>
     </ion-item>
diff --git a/ui/src/app/pages/server-routes/wifi/wifi.page.html b/ui/src/app/pages/server-routes/wifi/wifi.page.html
index 440fa8dee..ecce7352d 100644
--- a/ui/src/app/pages/server-routes/wifi/wifi.page.html
+++ b/ui/src/app/pages/server-routes/wifi/wifi.page.html
@@ -15,7 +15,7 @@
       <ion-label>
         <h2>
           Adding WiFi credentials to your Embassy allows you to remove the Ethernet cable and move the device anywhere you want. Embassy will automatically connect to available networks.
-          <a href="https://docs.start9.com/user-manual/general/wifi.html" target="_blank">View instructions</a>
+          <a href="https://docs.start9.com/user-manual/general/wifi.html" target="_blank" rel="noreferrer">View instructions</a>
         </h2>
       </ion-label>
     </ion-item>
diff --git a/ui/src/app/services/error-toast.service.ts b/ui/src/app/services/error-toast.service.ts
index 2d4175dc7..d89f01137 100644
--- a/ui/src/app/services/error-toast.service.ts
+++ b/ui/src/app/services/error-toast.service.ts
@@ -57,7 +57,7 @@ export function getErrorMessage (e: RequestError, link?: string): string | Ionic
   }
 
   if (link) {
-    message = new IonicSafeString(`${message}<br /><br /><a href=${link} target="_blank" style="color: white;">Get Help</a>`)
+    message = new IonicSafeString(`${message}<br /><br /><a href=${link} target="_blank" rel="noreferrer" style="color: white;">Get Help</a>`)
   }
 
   return message