Start9/start-os
2
0
Fork 0
mirror of https://github.com/Start9Labs/start-os.git synced 2026-03-30 20:14:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

reduce task leaking (#2868)

Browse Source 
* reduce task leaking

* fix onLeaveContext
This commit is contained in:
Aiden McClelland
2025-04-16 11:00:46 -06:00
committed by GitHub
parent 03f8b73627
commit 89f3fdc05f
18 changed files with 159 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
sdk/package/lib/mainFn/CommandController.ts
View File

@@ -130,39 +130,37 @@ export class CommandController extends Drop {
return new SubContainerHandle(this.subcontainer)
}
async wait({ timeout = NO_TIMEOUT } = {}) {
const self = this.weak()
if (timeout > 0)
setTimeout(() => {
self.term()
this.term()
}, timeout)
try {
return await self.runningAnswer
return await this.runningAnswer
} finally {
if (!self.state.exited) {
self.process.kill("SIGKILL")
if (!this.state.exited) {
this.process.kill("SIGKILL")
}
await self.subcontainer.destroy().catch((_) => {})
await this.subcontainer.destroy().catch((_) => {})
}
}
async term({ signal = SIGTERM, timeout = this.sigtermTimeout } = {}) {
const self = this.weak()
try {
if (!self.state.exited) {
if (!this.state.exited) {
if (signal !== "SIGKILL") {
setTimeout(() => {
if (!self.state.exited) self.process.kill("SIGKILL")
if (!this.state.exited) this.process.kill("SIGKILL")
}, timeout)
}
if (!self.process.kill(signal)) {
if (!this.process.kill(signal)) {
console.error(
`failed to send signal ${signal} to pid ${this.process.pid}`,
)
}
}
await self.runningAnswer
await this.runningAnswer
} finally {
await self.subcontainer.destroy()
await this.subcontainer.destroy()
}
}
onDrop(): void {