More svc effect handlers (#2610)

* complete get_primary_url fn

* complete clear_network_interfaces fn

* formatting

* complete remove_address fn

* get_system_smtp wip

* complete get_system_smtp and set_system_smtp

* add SetSystemSmtpParams struct

* add set_system_smtp subcommand

* Remove 'Copy' implementation from `HostAddress`

Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>

* Refactor `get_host_primary` fn and clone  resulting `HostAddress`

Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>

* misc fixes and debug info

* seed hosts with a tor address

---------

Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>
Co-authored-by: Aiden McClelland <me@drbonez.dev>

core/startos/src/registry/os/asset/add.rs

@@ -9,7 +9,7 @@ use futures::{FutureExt, TryStreamExt};
 use helpers::NonDetachingJoinHandle;
 use imbl_value::InternedString;
 use itertools::Itertools;
-use rpc_toolkit::{from_fn_async, CallRemote, Context, HandlerArgs, HandlerExt, ParentHandler};
+use rpc_toolkit::{from_fn_async, Context, HandlerArgs, HandlerExt, ParentHandler};
 use serde::{Deserialize, Serialize};
 use sha2::{Digest, Sha512};
 use ts_rs::TS;
@@ -106,9 +106,11 @@ async fn add_asset(
                         .as_idx_mut(&version)
                         .or_not_found(&version)?,
                 )
-                .upsert(&platform, || RegistryAsset {
-                    url,
-                    signature_info: SignatureInfo::new(SIG_CONTEXT),
+                .upsert(&platform, || {
+                    Ok(RegistryAsset {
+                        url,
+                        signature_info: SignatureInfo::new(SIG_CONTEXT),
+                    })
                 })?
                 .as_signature_info_mut()
                 .mutate(|s| s.add_sig(&signature))?;

core/startos/src/registry/os/version/mod.rs

@@ -81,7 +81,7 @@ pub async fn add_version(
             db.as_index_mut()
                 .as_os_mut()
                 .as_versions_mut()
-                .upsert(&version, || OsVersionInfo::default())?
+                .upsert(&version, || Ok(OsVersionInfo::default()))?
                 .mutate(|i| {
                     i.headline = headline;
                     i.release_notes = release_notes;