chore: enable strict mode (#1569)

* chore: enable strict mode

* refactor: remove sync data access from PatchDbService

* launchable even when no LAN url

Co-authored-by: Matt Hill <matthewonthemoon@gmail.com>

frontend/projects/setup-wizard/src/app/modals/password/password.page.html

@@ -1,24 +1,33 @@
 <ion-header>
   <ion-toolbar>
     <ion-title>
-      {{ !!storageDrive ? 'Set Password' : 'Unlock Drive' }}
+      {{ storageDrive ? 'Set Password' : 'Unlock Drive' }}
     </ion-title>
   </ion-toolbar>
 </ion-header>
 
 <ion-content>
-  <div style="padding: 8px 24px;">
-    <div style="padding-bottom: 16px;">
-      <ng-container *ngIf="!!storageDrive">
-        <p>Choose a password for your Embassy. <i>Make it good. Write it down.</i></p>
-        <p style="color: var(--ion-color-warning);">Losing your password can result in total loss of data.</p>
-      </ng-container>
-      <p *ngIf="!storageDrive">Enter the password that was used to encrypt this drive.</p>
+  <div style="padding: 8px 24px">
+    <div style="padding-bottom: 16px">
+      <ng-template #choose>
+        <p>
+          Choose a password for your Embassy.
+          <i>Make it good. Write it down.</i>
+        </p>
+        <p style="color: var(--ion-color-warning)">
+          Losing your password can result in total loss of data.
+        </p>
+      </ng-template>
+      <p *ngIf="!storageDrive else choose">
+        Enter the password that was used to encrypt this drive.
+      </p>
     </div>
 
-    <form (ngSubmit)="!!storageDrive ? submitPw() : verifyPw()">
+    <form (ngSubmit)="storageDrive ? submitPw() : verifyPw()">
       <p>Password</p>
-      <ion-item [class]="pwError ? 'error-border' : password && !!storageDrive ? 'success-border' : ''">
+      <ion-item
+        [class]="pwError ? 'error-border' : password && storageDrive ? 'success-border' : ''"
+      >
         <ion-input
           #focusInput
           [(ngModel)]="password"
@@ -29,15 +38,23 @@
           maxlength="64"
         ></ion-input>
         <ion-button fill="clear" color="light" (click)="unmasked1 = !unmasked1">
-          <ion-icon slot="icon-only" [name]="unmasked1 ? 'eye-off-outline' : 'eye-outline'" size="small"></ion-icon>
+          <ion-icon
+            slot="icon-only"
+            [name]="unmasked1 ? 'eye-off-outline' : 'eye-outline'"
+            size="small"
+          ></ion-icon>
         </ion-button>
       </ion-item>
-      <div style="height: 16px;">
-        <p style="color: var(--ion-color-danger); font-size: x-small;">{{ pwError }}</p>
+      <div style="height: 16px">
+        <p style="color: var(--ion-color-danger); font-size: x-small">
+          {{ pwError }}
+        </p>
       </div>
-      <ng-container *ngIf="!!storageDrive">
+      <ng-container *ngIf="storageDrive">
         <p>Confirm Password</p>
-        <ion-item [class]="verError ? 'error-border' : passwordVer ? 'success-border' : ''">
+        <ion-item
+          [class]="verError ? 'error-border' : passwordVer ? 'success-border' : ''"
+        >
           <ion-input
             [(ngModel)]="passwordVer"
             [ngModelOptions]="{'standalone': true}"
@@ -46,12 +63,22 @@
             maxlength="64"
             placeholder="Retype Password"
           ></ion-input>
-          <ion-button fill="clear" color="light" (click)="unmasked2 = !unmasked2">
-            <ion-icon slot="icon-only" [name]="unmasked2 ? 'eye-off-outline' : 'eye-outline'" size="small"></ion-icon>
+          <ion-button
+            fill="clear"
+            color="light"
+            (click)="unmasked2 = !unmasked2"
+          >
+            <ion-icon
+              slot="icon-only"
+              [name]="unmasked2 ? 'eye-off-outline' : 'eye-outline'"
+              size="small"
+            ></ion-icon>
           </ion-button>
         </ion-item>
-        <div style="height: 16px;">
-          <p style="color: var(--ion-color-danger); font-size: x-small;">{{ verError }}</p>
+        <div style="height: 16px">
+          <p style="color: var(--ion-color-danger); font-size: x-small">
+            {{ verError }}
+          </p>
         </div>
       </ng-container>
       <input type="submit" style="display: none" />
@@ -61,12 +88,24 @@
 
 <ion-footer>
   <ion-toolbar>
-    <ion-button class="ion-padding-end" slot="end" color="dark" fill="clear" (click)="cancel()">
+    <ion-button
+      class="ion-padding-end"
+      slot="end"
+      color="dark"
+      fill="clear"
+      (click)="cancel()"
+    >
       Cancel
     </ion-button>
-    <ion-button class="ion-padding-end" slot="end" color="dark" fill="clear" strong="true" (click)="!!storageDrive ? submitPw() : verifyPw()">
-      {{ !!storageDrive ? 'Finish' : 'Unlock' }}
+    <ion-button
+      class="ion-padding-end"
+      slot="end"
+      color="dark"
+      fill="clear"
+      strong="true"
+      (click)="storageDrive ? submitPw() : verifyPw()"
+    >
+      {{ storageDrive ? 'Finish' : 'Unlock' }}
     </ion-button>
   </ion-toolbar>
 </ion-footer>
-

frontend/projects/setup-wizard/src/app/modals/password/password.page.ts

@@ -13,9 +13,9 @@ import * as argon2 from '@start9labs/argon2'
   styleUrls: ['password.page.scss'],
 })
 export class PasswordPage {
-  @ViewChild('focusInput') elem: IonInput
-  @Input() target: CifsBackupTarget | DiskBackupTarget
-  @Input() storageDrive: DiskInfo
+  @ViewChild('focusInput') elem?: IonInput
+  @Input() target?: CifsBackupTarget | DiskBackupTarget
+  @Input() storageDrive?: DiskInfo
 
   pwError = ''
   password = ''
@@ -28,7 +28,7 @@ export class PasswordPage {
   constructor(private modalController: ModalController) {}
 
   ngAfterViewInit() {
-    setTimeout(() => this.elem.setFocus(), 400)
+    setTimeout(() => this.elem?.setFocus(), 400)
   }
 
   async verifyPw() {
@@ -36,7 +36,7 @@ export class PasswordPage {
       this.pwError = 'No recovery target' // unreachable
 
     try {
-      const passwordHash = this.target['embassy-os']?.['password-hash'] || ''
+      const passwordHash = this.target!['embassy-os']?.['password-hash'] || ''
 
       argon2.verify(passwordHash, this.password)
       this.modalController.dismiss({ password: this.password }, 'success')

frontend/projects/setup-wizard/src/app/modals/prod-key-modal/prod-key-modal.page.ts

@@ -9,8 +9,8 @@ import { HttpService } from 'src/app/services/api/http.service'
   styleUrls: ['prod-key-modal.page.scss'],
 })
 export class ProdKeyModal {
-  @ViewChild('focusInput') elem: IonInput
-  @Input() target: DiskBackupTarget
+  @ViewChild('focusInput') elem?: IonInput
+  @Input() target!: DiskBackupTarget
 
   error = ''
   productKey = ''
@@ -24,7 +24,7 @@ export class ProdKeyModal {
   ) {}
 
   ngAfterViewInit() {
-    setTimeout(() => this.elem.setFocus(), 400)
+    setTimeout(() => this.elem?.setFocus(), 400)
   }
 
   async verifyProductKey() {