misc sdk changes (#2934)

* misc sdk changes

* delete the store ☠️

* port comments

* fix build

* fix removing

* fix tests

* beta.20

---------

Co-authored-by: Matt Hill <mattnine@protonmail.com>

sdk/package/lib/test/inputSpecBuilder.test.ts

@@ -421,25 +421,16 @@ describe("values", () => {
             },
           }),
         )
-        .withStore<{ test: "a" }>()
         .build(true)
 
-      const value = Value.dynamicDatetime<{ test: "a" }>(
-        async ({ effects }) => {
-          ;async () => {
-            ;(await sdk.store
-              .getOwn(effects, sdk.StorePath.test)
-              .once()) satisfies "a"
-          }
-
-          return {
-            name: "Testing",
-            required: true,
-            default: null,
-            inputmode: "date",
-          }
-        },
-      )
+      const value = Value.dynamicDatetime(async ({ effects }) => {
+        return {
+          name: "Testing",
+          required: true,
+          default: null,
+          inputmode: "date",
+        }
+      })
       const validator = value.validator
       validator.unsafeCast("2021-01-01")
       validator.unsafeCast(null)

sdk/package/lib/test/output.sdk.ts

@@ -1,4 +1,3 @@
-import { CurrentDependenciesResult } from "../../../base/lib/dependencies/setupDependencies"
 import { StartSdk } from "../StartSdk"
 import { setupManifest } from "../manifest/setupManifest"
 import { VersionGraph } from "../version/VersionGraph"
@@ -49,5 +48,4 @@ export const sdk = StartSdk.of()
       },
     }),
   )
-  .withStore<{ storeRoot: { storeLeaf: "value" } }>()
   .build(true)

sdk/package/lib/test/store.test.ts

@@ -1,111 +0,0 @@
-import { Effects } from "../../../base/lib/types"
-import { extractJsonPath } from "../../../base/lib/util/PathBuilder"
-import { StartSdk } from "../StartSdk"
-
-type Store = {
-  inputSpec: {
-    someValue: "a" | "b"
-  }
-}
-type Manifest = any
-const todo = <A>(): A => {
-  throw new Error("not implemented")
-}
-const noop = () => {}
-
-const sdk = StartSdk.of()
-  .withManifest({} as Manifest)
-  .withStore<Store>()
-  .build(true)
-
-const storePath = sdk.StorePath
-
-describe("Store", () => {
-  test("types", async () => {
-    ;async () => {
-      sdk.store.setOwn(todo<Effects>(), storePath.inputSpec, {
-        someValue: "a",
-      })
-      sdk.store.setOwn(todo<Effects>(), storePath.inputSpec.someValue, "b")
-      sdk.store.setOwn(todo<Effects>(), storePath, {
-        inputSpec: { someValue: "b" },
-      })
-      sdk.store.setOwn(
-        todo<Effects>(),
-        storePath.inputSpec.someValue,
-
-        // @ts-expect-error Type is wrong for the setting value
-        5,
-      )
-      sdk.store.setOwn(
-        todo<Effects>(),
-        // @ts-expect-error Path is wrong
-        "/inputSpec/someVae3lue",
-        "someValue",
-      )
-
-      todo<Effects>().store.set<Store>({
-        path: extractJsonPath(storePath.inputSpec.someValue),
-        value: "b",
-      })
-      todo<Effects>().store.set<Store, "/inputSpec/some2Value">({
-        path: extractJsonPath(storePath.inputSpec.someValue),
-        //@ts-expect-error Path is wrong
-        value: "someValueIn",
-      })
-      ;(await sdk.store
-        .getOwn(todo<Effects>(), storePath.inputSpec.someValue)
-        .const()) satisfies string
-      ;(await sdk.store
-        .getOwn(todo<Effects>(), storePath.inputSpec)
-        .const()) satisfies Store["inputSpec"]
-      await sdk.store // @ts-expect-error Path is wrong
-        .getOwn(todo<Effects>(), "/inputSpec/somdsfeValue")
-        .const()
-      ///  ----------------- ERRORS -----------------
-
-      sdk.store.setOwn(todo<Effects>(), storePath, {
-        // @ts-expect-error Type is wrong for the setting value
-        inputSpec: { someValue: "notInAOrB" },
-      })
-      sdk.store.setOwn(
-        todo<Effects>(),
-        sdk.StorePath.inputSpec.someValue,
-        // @ts-expect-error Type is wrong for the setting value
-        "notInAOrB",
-      )
-      ;(await sdk.store
-        .getOwn(todo<Effects>(), storePath.inputSpec.someValue)
-        .const()) satisfies string
-      ;(await sdk.store
-        .getOwn(todo<Effects>(), storePath.inputSpec)
-        .const()) satisfies Store["inputSpec"]
-      await sdk.store // @ts-expect-error Path is wrong
-        .getOwn("/inputSpec/somdsfeValue")
-        .const()
-
-      ///
-      ;(await sdk.store
-        .getOwn(todo<Effects>(), storePath.inputSpec.someValue)
-        // @ts-expect-error satisfies type is wrong
-        .const()) satisfies number
-      await sdk.store // @ts-expect-error Path is wrong
-        .getOwn(todo<Effects>(), extractJsonPath(storePath.inputSpec))
-        .const()
-      ;(await todo<Effects>().store.get({
-        path: extractJsonPath(storePath.inputSpec.someValue),
-        callback: noop,
-      })) satisfies string
-      await todo<Effects>().store.get<Store, "/inputSpec/someValue">({
-        // @ts-expect-error Path is wrong as in it doesn't match above
-        path: "/inputSpec/someV2alue",
-        callback: noop,
-      })
-      await todo<Effects>().store.get<Store, "/inputSpec/someV2alue">({
-        // @ts-expect-error Path is wrong as in it doesn't exists in wrapper type
-        path: "/inputSpec/someV2alue",
-        callback: noop,
-      })
-    }
-  })
-})