Start9/start-os
2
0
Fork 0
mirror of https://github.com/Start9Labs/start-os.git synced 2026-03-30 12:11:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: replace .status() with .invoke() for iptables/ip commands

Browse Source 
Using .status() leaks stderr directly to system logs, causing noisy
iptables error messages. Switch all networking CLI invocations to use
.invoke() which captures stderr properly. For check-then-act patterns
(iptables -C), use .invoke().await.is_err() instead of
.status().await.map_or(false, |s| s.success()).
This commit is contained in:
Aiden McClelland
2026-02-17 14:12:29 -07:00
parent bc4478b0b9
commit 5fbc73755d
4 changed files with 183 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/net/forward.rs
View File

@@ -254,7 +254,8 @@ pub async fn add_iptables_rule(nat: bool, undo: bool, args: &[&str]) -> Result<(
if nat {
cmd.arg("-t").arg("nat");
}
if undo != !cmd.arg("-C").args(args).status().await?.success() {
let exists = cmd.arg("-C").args(args).invoke(ErrorKind::Network).await.is_ok();
if undo != !exists {
let mut cmd = Command::new("iptables");
if nat {
cmd.arg("-t").arg("nat");