From 44af3fe781ebbbc78e3e951e4c9a73886ef5026f Mon Sep 17 00:00:00 2001
From: Drew Ansbacher <drew.ansbacher@spiredigital.com>
Date: Thu, 24 Jun 2021 11:02:02 -0600
Subject: [PATCH] just using model in the html

---
 .../apps-routes/release-notes/release-notes.page.html |  4 ++--
 .../apps-routes/release-notes/release-notes.page.ts   | 11 ++++-------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/ui/src/app/pages/apps-routes/release-notes/release-notes.page.html b/ui/src/app/pages/apps-routes/release-notes/release-notes.page.html
index 98500e73b..ac5b8df34 100644
--- a/ui/src/app/pages/apps-routes/release-notes/release-notes.page.html
+++ b/ui/src/app/pages/apps-routes/release-notes/release-notes.page.html
@@ -8,10 +8,10 @@
 </ion-header>
 
 <ion-content>
-  <ion-spinner *ngIf="!releaseNotes; else loaded" class="center" name="lines" color="warning"></ion-spinner>
+  <ion-spinner *ngIf="!releaseNotesModel.releaseNotes; else loaded" class="center" name="lines" color="warning"></ion-spinner>
 
   <ng-template #loaded>
-    <div *ngFor="let note of releaseNotes | keyvalue : asIsOrder">
+    <div *ngFor="let note of releaseNotesModel.releaseNotes | keyvalue : asIsOrder">
       <ion-button (click)="setSelected(note.key)"  expand="full" color="light" style="height: 50px;" >
         <p style="position: absolute; left: 10px;">{{note.key | displayEmver}}</p>
       </ion-button>
diff --git a/ui/src/app/pages/apps-routes/release-notes/release-notes.page.ts b/ui/src/app/pages/apps-routes/release-notes/release-notes.page.ts
index 1a58d464c..0cee9aafb 100644
--- a/ui/src/app/pages/apps-routes/release-notes/release-notes.page.ts
+++ b/ui/src/app/pages/apps-routes/release-notes/release-notes.page.ts
@@ -11,20 +11,17 @@ import { ReleaseNoteModel } from './release-notes.model'
 export class ReleaseNotes {
   error = ''
   pkgId: string
-  releaseNotes: { [version: string]: string}
   selected: string
 
   constructor (
     private readonly route: ActivatedRoute,
     private readonly apiService: ApiService,
-    private releaseNoteModel: ReleaseNoteModel,
-  ) {
-      this.releaseNotes = releaseNoteModel.releaseNotes
-   }
+    public releaseNotesModel: ReleaseNoteModel,
+  ) { }
 
   ngOnInit () {
     this.pkgId = this.route.snapshot.paramMap.get('pkgId')
-    if (!this.releaseNotes) {
+    if (!this.releaseNotesModel.releaseNotes) {
       this.getReleaseNotes()
     }
   }
@@ -32,7 +29,7 @@ export class ReleaseNotes {
   async getReleaseNotes (version?: string): Promise<void> {
     try {
       const pkg = await this.apiService.getAvailableShow({ id: this.pkgId, version })
-      this.releaseNotes = pkg['release-notes']
+      this.releaseNotesModel.releaseNotes = pkg['release-notes']
     } catch (e) {
       console.error(e)
       this.error = e.message