Refactor/sdk init (#2947)

* fixes for main

* refactor package initialization

* fixes from testing

* more fixes

* beta.21

* do not use instanceof

* closes #2921

* beta22

* allow disabling kiosk

* migration

* fix /etc/shadow

* actionRequest -> task

* beta.23

sdk/base/lib/actions/input/builder/value.ts

@@ -919,36 +919,6 @@ export class Value<Type> {
       aVariants.validator,
     )
   }
-  static filteredUnion<
-    VariantValues extends {
-      [K in string]: {
-        name: string
-        spec: InputSpec<any>
-      }
-    },
-  >(
-    getDisabledFn: LazyBuild<string[] | false | string>,
-    a: {
-      name: string
-      description?: string | null
-      warning?: string | null
-      default: keyof VariantValues & string
-    },
-    aVariants: Variants<VariantValues>,
-  ) {
-    return new Value<typeof aVariants.validator._TYPE>(
-      async (options) => ({
-        type: "union" as const,
-        description: null,
-        warning: null,
-        ...a,
-        variants: await aVariants.build(options as any),
-        disabled: (await getDisabledFn(options)) || false,
-        immutable: false,
-      }),
-      aVariants.validator,
-    )
-  }
   static dynamicUnion<
     VariantValues extends {
       [K in string]: {

sdk/base/lib/actions/input/inputSpecConstants.ts

@@ -45,15 +45,16 @@ export const customSmtp = InputSpec.of<InputSpecOf<SmtpValue>>({
 /**
  * For service inputSpec. Gives users 3 options for SMTP: (1) disabled, (2) use system SMTP settings, (3) use custom SMTP settings
  */
-export const smtpInputSpec = Value.filteredUnion(
+export const smtpInputSpec = Value.dynamicUnion(
   async ({ effects }) => {
     const smtp = await new GetSystemSmtp(effects).once()
-    return smtp ? [] : ["system"]
-  },
-  {
-    name: "SMTP",
-    description: "Optionally provide an SMTP server for sending emails",
-    default: "disabled",
+    const disabled = smtp ? [] : ["system"]
+    return {
+      name: "SMTP",
+      description: "Optionally provide an SMTP server for sending emails",
+      default: "disabled",
+      disabled,
+    }
   },
   Variants.of({
     disabled: { name: "Disabled", spec: InputSpec.of({}) },