From 3d39b5653d59d3274923c95acd673d4094e53b3f Mon Sep 17 00:00:00 2001 From: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com> Date: Fri, 17 Mar 2023 12:09:24 -0600 Subject: [PATCH] don't blow up if s9pk fails to load (#2231) --- backend/src/install/mod.rs | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/backend/src/install/mod.rs b/backend/src/install/mod.rs index e63cfa52f..72f5c500b 100644 --- a/backend/src/install/mod.rs +++ b/backend/src/install/mod.rs @@ -1435,16 +1435,22 @@ pub fn load_images<'a, P: AsRef + 'a + Send + Sync>( copy_and_shutdown(&mut File::open(&path).await?, load_in) .await? } - Some("s9pk") => { - copy_and_shutdown( - &mut S9pkReader::open(&path, false) - .await? - .docker_images() - .await?, - load_in, - ) - .await? + Some("s9pk") => match async { + let mut reader = S9pkReader::open(&path, true).await?; + copy_and_shutdown(&mut reader.docker_images().await?, load_in) + .await?; + Ok::<_, Error>(()) } + .await + { + Ok(()) => (), + Err(e) => { + tracing::error!( + "Error loading docker images from s9pk: {e}" + ); + tracing::debug!("{e:?}"); + } + }, _ => unreachable!(), };