update/alpha.9 (#2988)

* import marketplac preview for sideload

* fix: improve state service (#2977)

* fix: fix sideload DI

* fix: update Angular

* fix: cleanup

* fix: fix version selection

* Bump node version to fix build for Angular

* misc fixes
- update node to v22
- fix chroot-and-upgrade access to prune-images
- don't self-migrate legacy packages
- #2985
- move dataVersion to volume folder
- remove "instructions.md" from s9pk
- add "docsUrl" to manifest

* version bump

* include flavor when clicking view listing from updates tab

* closes #2980

* fix: fix select button

* bring back ssh keys

* fix: drop 'portal' from all routes

* fix: implement longtap action to select table rows

* fix description for ssh page

* replace instructions with docsLink and refactor marketplace preview

* delete unused translations

* fix patchdb diffing algorithm

* continue refactor of marketplace lib show components

* Booting StartOS instead of Setting up your server on init

* misc fixes
- closes #2990
- closes #2987

* fix build

* docsUrl and clickable service headers

* don't cleanup after update until new service install succeeds

* update types

* misc fixes

* beta.35

* sdkversion, githash for sideload, correct logs for init, startos pubkey display

* bring back reboot button on install

* misc fixes

* beta.36

* better handling of setup and init for websocket errors

* reopen init and setup logs even on graceful closure

* better logging, misc fixes

* fix build

* dont let package stats hang

* dont show docsurl in marketplace if no docsurl

* re-add needs-config

* show error if init fails, shorten hover state on header icons

* fix operator precedemce

---------

Co-authored-by: Matt Hill <mattnine@protonmail.com>
Co-authored-by: Alex Inkin <alexander@inkin.ru>
Co-authored-by: Mariusz Kogen <k0gen@pm.me>

container-runtime/src/Adapters/Systems/SystemForEmbassy/index.ts

@@ -289,6 +289,7 @@ function convertProperties(
 
 const DEFAULT_REGISTRY = "https://registry.start9.com"
 export class SystemForEmbassy implements System {
+  private version: ExtendedVersion
   currentRunning: MainLoop | undefined
   static async of(manifestLocation: string = MANIFEST_LOCATION) {
     const moduleCode = await import(EMBASSY_JS_LOCATION)
@@ -310,7 +311,27 @@ export class SystemForEmbassy implements System {
   constructor(
     readonly manifest: Manifest,
     readonly moduleCode: Partial<U.ExpectedExports>,
-  ) {}
+  ) {
+    this.version = ExtendedVersion.parseEmver(manifest.version)
+    if (
+      this.manifest.id === "bitcoind" &&
+      this.manifest.title.toLowerCase().includes("knots")
+    )
+      this.version.flavor = "knots"
+
+    if (
+      this.manifest.id === "lnd" ||
+      this.manifest.id === "ride-the-lightning" ||
+      this.manifest.id === "datum"
+    ) {
+      this.version.upstream.prerelease = ["beta"]
+    } else if (
+      this.manifest.id === "lightning-terminal" ||
+      this.manifest.id === "robosats"
+    ) {
+      this.version.upstream.prerelease = ["alpha"]
+    }
+  }
 
   async init(
     effects: Effects,
@@ -394,27 +415,9 @@ export class SystemForEmbassy implements System {
         reason: "This service must be configured before it can be run",
       })
     }
-    const version = ExtendedVersion.parseEmver(this.manifest.version)
-    if (
-      this.manifest.id === "bitcoind" &&
-      this.manifest.title.toLowerCase().includes("knots")
-    )
-      version.flavor = "knots"
 
-    if (
-      this.manifest.id === "lnd" ||
-      this.manifest.id === "ride-the-lightning" ||
-      this.manifest.id === "datum"
-    ) {
-      version.upstream.prerelease = ["beta"]
-    } else if (
-      this.manifest.id === "lightning-terminal" ||
-      this.manifest.id === "robosats"
-    ) {
-      version.upstream.prerelease = ["alpha"]
-    }
     await effects.setDataVersion({
-      version: version.toString(),
+      version: this.version.toString(),
     })
     // @FullMetal: package hacks go here
   }
@@ -599,10 +602,7 @@ export class SystemForEmbassy implements System {
     timeoutMs?: number | null,
   ): Promise<void> {
     await this.currentRunning?.clean({ timeout: timeoutMs ?? undefined })
-    if (
-      target &&
-      !overlaps(target, ExtendedVersion.parseEmver(this.manifest.version))
-    ) {
+    if (target) {
       await this.migration(effects, { to: target }, timeoutMs ?? null)
     }
     await effects.setMainStatus({ status: "stopped" })
@@ -823,6 +823,7 @@ export class SystemForEmbassy implements System {
     let migration
     let args: [string, ...string[]]
     if ("from" in version) {
+      if (overlaps(this.version, version.from)) return null
       args = [version.from.toString(), "from"]
       if (!this.manifest.migrations) return { configured: true }
       migration = Object.entries(this.manifest.migrations.from)
@@ -832,6 +833,7 @@ export class SystemForEmbassy implements System {
         )
         .find(([versionEmver, _]) => overlaps(versionEmver, version.from))
     } else {
+      if (overlaps(this.version, version.to)) return null
       args = [version.to.toString(), "to"]
       if (!this.manifest.migrations) return { configured: true }
       migration = Object.entries(this.manifest.migrations.to)
@@ -1043,10 +1045,10 @@ export class SystemForEmbassy implements System {
       .withPath(`/media/embassy/${id}/config.json`)
       .read()
       .onChange(effects, async (oldConfig: U.Config) => {
-        if (!oldConfig) return
+        if (!oldConfig) return { cancel: false }
         const moduleCode = await this.moduleCode
         const method = moduleCode?.dependencies?.[id]?.autoConfigure
-        if (!method) return
+        if (!method) return { cancel: true }
         const newConfig = (await method(
           polyfillEffects(effects, this.manifest),
           JSON.parse(JSON.stringify(oldConfig)),
@@ -1073,6 +1075,7 @@ export class SystemForEmbassy implements System {
             },
           })
         }
+        return { cancel: false }
       })
   }
 }