remove sourceVersion and minor cleanup

This commit is contained in:
Matt Hill
2024-07-29 22:42:17 -06:00
parent 1dd21f1f76
commit 290a15bbd9
6 changed files with 10 additions and 16 deletions

View File

@@ -38,7 +38,7 @@ export class LiveApiService extends ApiService {
@Inject(PATCH_CACHE) private readonly cache$: Observable<Dump<DataModel>>,
) {
super()
;(window as any).rpcClient = this
; (window as any).rpcClient = this
}
// for sideloading packages
@@ -321,7 +321,6 @@ export class LiveApiService extends ApiService {
const params: GetPackageReq = {
id,
version: versionRange,
sourceVersion: null,
otherVersions: 'short',
}
@@ -335,7 +334,6 @@ export class LiveApiService extends ApiService {
const params: GetPackagesReq = {
id: null,
version: null,
sourceVersion: null,
otherVersions: 'short',
}

View File

@@ -41,7 +41,7 @@ export class PatchDbSource extends Observable<Update<DataModel>[]> {
catchError((_, original$) => {
this.state.retrigger()
// @TODO this is returning right away, but we need to wait until state emits again from the retrigger() above.
// @TODO Alex this is returning right away and crashing the browser, but we need to wait until state emits again from the retrigger() above.
return this.state.pipe(
filter(current => current === 'running'),
take(1),

View File

@@ -111,7 +111,7 @@ export class StateService extends Observable<RR.ServerState | null> {
),
),
)
.subscribe() // @TODO shouldn't this be subscribed in app component with the others? Do we ever need to unsubscribe?
.subscribe() // @TODO Alex shouldn't this be subscribed in app component with the others? Do we ever need to unsubscribe?
constructor() {
super(subscriber => this.stream$.subscribe(subscriber))