From 16802675680950cf62bf96c4ad8ab10281a96f81 Mon Sep 17 00:00:00 2001
From: Drew Ansbacher <drew.ansbacher@spiredigital.com>
Date: Sat, 4 Sep 2021 00:27:10 +0300
Subject: [PATCH] matt commets addressed

---
 .../components/skeleton-list/skeleton-list.component.ts   | 4 ++--
 .../pages/apps-routes/app-metrics/app-metrics.page.html   | 2 +-
 ui/src/app/pages/apps-routes/app-show/app-show.page.html  | 2 +-
 .../marketplace-show/marketplace-show.page.ts             | 2 +-
 .../server-routes/server-metrics/server-metrics.page.html | 2 +-
 ui/src/app/services/patch-db/data-model.ts                | 8 ++++----
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/ui/src/app/components/skeleton-list/skeleton-list.component.ts b/ui/src/app/components/skeleton-list/skeleton-list.component.ts
index 2f8e5d793..9cdf215b4 100644
--- a/ui/src/app/components/skeleton-list/skeleton-list.component.ts
+++ b/ui/src/app/components/skeleton-list/skeleton-list.component.ts
@@ -6,8 +6,8 @@ import { Component, Input } from '@angular/core'
   styleUrls: ['./skeleton-list.component.scss'],
 })
 export class SkeletonListComponent {
-  @Input() groups: number
-  @Input() rows: number = 3
+  @Input() groups: string
+  @Input() rows: string = '3'
   groupsArr: number[] = []
   rowsArr: number[] = []
 
diff --git a/ui/src/app/pages/apps-routes/app-metrics/app-metrics.page.html b/ui/src/app/pages/apps-routes/app-metrics/app-metrics.page.html
index a624d2a26..5aee68a73 100644
--- a/ui/src/app/pages/apps-routes/app-metrics/app-metrics.page.html
+++ b/ui/src/app/pages/apps-routes/app-metrics/app-metrics.page.html
@@ -9,7 +9,7 @@
 
 <ion-content class="ion-padding">
 
-  <skeleton-list *ngIf="loading" [rows]="3"></skeleton-list>
+  <skeleton-list *ngIf="loading" rows="3"></skeleton-list>
   <ion-item-group *ngIf="!loading">
     <ion-item *ngFor="let metric of metrics | keyvalue : asIsOrder">
       <ion-label>{{ metric.key }}</ion-label>
diff --git a/ui/src/app/pages/apps-routes/app-show/app-show.page.html b/ui/src/app/pages/apps-routes/app-show/app-show.page.html
index a5dac0d74..803d9b5ed 100644
--- a/ui/src/app/pages/apps-routes/app-show/app-show.page.html
+++ b/ui/src/app/pages/apps-routes/app-show/app-show.page.html
@@ -100,7 +100,7 @@
                 <p><ion-text [color]="pkg.installed.status['dependency-errors'][dep.key] ? 'warning' : 'success'">{{ pkg.installed.status['dependency-errors'][dep.key] ? pkg.installed.status['dependency-errors'][dep.key].type : 'satisfied' }}</ion-text></p>
               </ion-label>
 
-              <ion-button *ngIf="!pkg.installed.status['dependency-errors'][dep.key] || (pkg.installed.status['dependency-errors'][dep.key] && [DependencyErrorType.InterfaceHealthChecksFailed, DependencyErrorType.HealthCheckFailed] | includes : pkg.installed.status['dependency-errors'][dep.key].type)" slot="end" size="small" [routerLink]="['/services', dep.key]">
+              <ion-button *ngIf="!pkg.installed.status['dependency-errors'][dep.key] || (pkg.installed.status['dependency-errors'][dep.key] && [DependencyErrorType.InterfaceHealthCheckFailed, DependencyErrorType.HealthCheckFailed] | includes : pkg.installed.status['dependency-errors'][dep.key].type)" slot="end" size="small" [routerLink]="['/services', dep.key]">
                 View
               </ion-button>
 
diff --git a/ui/src/app/pages/marketplace-routes/marketplace-show/marketplace-show.page.ts b/ui/src/app/pages/marketplace-routes/marketplace-show/marketplace-show.page.ts
index 0db97ba51..ccf1a516e 100644
--- a/ui/src/app/pages/marketplace-routes/marketplace-show/marketplace-show.page.ts
+++ b/ui/src/app/pages/marketplace-routes/marketplace-show/marketplace-show.page.ts
@@ -38,7 +38,7 @@ export class MarketplaceShowPage {
     private readonly navCtrl: NavController,
     private readonly emver: Emver,
     private readonly patch: PatchDbService,
-    readonly marketplaceService: MarketplaceService,
+    public readonly marketplaceService: MarketplaceService,
   ) { }
 
   async ngOnInit () {
diff --git a/ui/src/app/pages/server-routes/server-metrics/server-metrics.page.html b/ui/src/app/pages/server-routes/server-metrics/server-metrics.page.html
index 2ff89e731..13e5ff85a 100644
--- a/ui/src/app/pages/server-routes/server-metrics/server-metrics.page.html
+++ b/ui/src/app/pages/server-routes/server-metrics/server-metrics.page.html
@@ -8,7 +8,7 @@
 </ion-header>
 
 <ion-content class="ion-padding">
-  <skeleton-list *ngIf="loading; else loaded" [groups]="2"></skeleton-list>
+  <skeleton-list *ngIf="loading; else loaded" groups="2"></skeleton-list>
 
   <ng-template #loaded>
     <ion-item-group *ngFor="let metricGroup of metrics | keyvalue : asIsOrder">
diff --git a/ui/src/app/services/patch-db/data-model.ts b/ui/src/app/services/patch-db/data-model.ts
index 30d19af6c..c225f5893 100644
--- a/ui/src/app/services/patch-db/data-model.ts
+++ b/ui/src/app/services/patch-db/data-model.ts
@@ -297,7 +297,7 @@ export interface HealthCheckResultFailure {
   error: string
 }
 
-export type DependencyError = DependencyErrorNotInstalled | DependencyErrorNotRunning | DependencyErrorIncorrectVersion | DependencyErrorConfigUnsatisfied | DependencyErrorHealthCheckFailed | DependencyErrorInterfaceHealthChecksFailed
+export type DependencyError = DependencyErrorNotInstalled | DependencyErrorNotRunning | DependencyErrorIncorrectVersion | DependencyErrorConfigUnsatisfied | DependencyErrorHealthCheckFailed | DependencyErrorInterfaceHealthCheckFailed
 
 export enum DependencyErrorType {
   NotInstalled = 'not-installed',
@@ -305,7 +305,7 @@ export enum DependencyErrorType {
   IncorrectVersion = 'incorrect-version',
   ConfigUnsatisfied = 'config-unsatisfied',
   HealthCheckFailed = 'health-check-failed',
-  InterfaceHealthChecksFailed = 'interface-health-checks-failed',
+  InterfaceHealthCheckFailed = 'interface-health-checks-failed',
 }
 
 export interface DependencyErrorNotInstalled {
@@ -332,8 +332,8 @@ export interface DependencyErrorHealthCheckFailed {
   check: HealthCheckResult
 }
 
-export interface DependencyErrorInterfaceHealthChecksFailed {
-  type: DependencyErrorType.InterfaceHealthChecksFailed
+export interface DependencyErrorInterfaceHealthCheckFailed {
+  type: DependencyErrorType.InterfaceHealthCheckFailed
   failures: { [id: string]: HealthCheckResult }
 }