rework to normalize version in db and small cleanups

test/Handler/AppSpec.hs

@@ -3,8 +3,10 @@
 module Handler.AppSpec (spec) where
 
 import Startlude
-import TestImport
 import Database.Persist.Sql
+import Data.Maybe
+
+import TestImport
 import Model
 
 spec :: Spec
@@ -23,6 +25,12 @@ spec = do
                 setMethod "GET"
                 setUrl ("/apps/bitcoind.s9pk?spec=0.18.3" :: Text)
             statusIs 404
+    describe "GET /apps/:appId with unknown app" $
+        withApp $ it "fails to get an unregistered app" $ do
+            request $ do
+                setMethod "GET"
+                setUrl ("/apps/tempapp.s9pk?spec=0.0.1" :: Text)
+            statusIs 404
     describe "GET /apps/:appId with existing version spec for bitcoin" $
         withApp $ it "creates app and metric records" $ do
             request $ do
@@ -43,3 +51,6 @@ spec = do
             metrics <- runDBtest $ selectList [MetricEvent ==. "cups"] []
             assertEq "app should exist" (length apps) 1
             assertEq "metric should exist" (length metrics) 1
+            let app = fromJust $ head apps
+            version <- runDBtest $ selectList [VersionAppId ==. entityKey app] []
+            assertEq "version should exist" (length version) 1