Start9/registry
2
0
Fork 0
mirror of https://github.com/Start9Labs/registry.git synced 2026-04-04 13:49:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

clean up question + todo

Browse Source
This commit is contained in:
Keagan McClelland
2022-05-26 16:15:50 -06:00
parent fc8f671e3d
commit 460177d242
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Util/Shared.hs
View File

@@ -134,17 +134,15 @@ filterDependencyBestVersion :: MonadLogger m => PackageDependencyMetadata -> m (
filterDependencyBestVersion PackageDependencyMetadata { packageDependencyMetadataPkgDependencyRecord = pkgDepRecord, packageDependencyMetadataDepVersions = depVersions } filterDependencyBestVersion PackageDependencyMetadata { packageDependencyMetadataPkgDependencyRecord = pkgDepRecord, packageDependencyMetadataDepVersions = depVersions }
= do = do
-- get best version from VersionRange of dependency -- get best version from VersionRange of dependency
let pkgId = pkgDependencyPkgId $ entityVal pkgDepRecord let pkgId = pkgDependencyPkgId $ entityVal pkgDepRecord
let depId = pkgDependencyDepId $ entityVal pkgDepRecord let depId = pkgDependencyDepId $ entityVal pkgDepRecord
let satisfactory = filter let versionRequirement = pkgDependencyDepVersionRange $ entityVal pkgDepRecord
((<|| (pkgDependencyDepVersionRange $ entityVal pkgDepRecord)) . versionRecordNumber) let satisfactory = filter ((<|| versionRequirement) . versionRecordNumber) (entityVal <$> depVersions)
(entityVal <$> depVersions)
case maximumOn versionRecordNumber satisfactory of case maximumOn versionRecordNumber satisfactory of
-- QUESTION is this an acceptable transformation here? These are the only values that we care about after this filter.
Just bestVersion -> pure $ Just (depId, versionRecordTitle bestVersion, versionRecordNumber bestVersion) Just bestVersion -> pure $ Just (depId, versionRecordTitle bestVersion, versionRecordNumber bestVersion)
Nothing -> do Nothing -> do
-- TODO it would be better if we could return the requirements for display $logInfo
$logInfo [i|No satisfactory version of #{depId} for dependent package #{pkgId}|] [i|No satisfactory version of #{depId} for dependent package #{pkgId}, needs #{versionRequirement}|]
pure Nothing pure Nothing
sendResponseText :: MonadHandler m => Status -> Text -> m a sendResponseText :: MonadHandler m => Status -> Text -> m a